issue_comments

Table actions

8 rows where issue = 359449421 sorted by updated_at descending

✖
✖

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: created_at (date), updated_at (date)

author_association 3

issue 1

  • Allow passing of positional arguments in `apply` for Groupby objects · 8 ✖
id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
449759022 https://github.com/pydata/xarray/pull/2413#issuecomment-449759022 https://api.github.com/repos/pydata/xarray/issues/2413 MDEyOklzc3VlQ29tbWVudDQ0OTc1OTAyMg== shoyer 1217238 2018-12-24T17:50:29Z 2018-12-24T17:50:29Z MEMBER

Thanks!

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Allow passing of positional arguments in `apply` for Groupby objects 359449421
448674355 https://github.com/pydata/xarray/pull/2413#issuecomment-448674355 https://api.github.com/repos/pydata/xarray/issues/2413 MDEyOklzc3VlQ29tbWVudDQ0ODY3NDM1NQ== pep8speaks 24736507 2018-12-19T17:16:27Z 2018-12-24T17:50:18Z NONE

Hello @maaleske! Thanks for updating the PR.

Cheers ! There are no PEP8 issues in this Pull Request. :beers:

Comment last updated on December 24, 2018 at 17:50 Hours UTC
 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Allow passing of positional arguments in `apply` for Groupby objects 359449421
433756046 https://github.com/pydata/xarray/pull/2413#issuecomment-433756046 https://api.github.com/repos/pydata/xarray/issues/2413 MDEyOklzc3VlQ29tbWVudDQzMzc1NjA0Ng== dcherian 2448579 2018-10-29T00:17:53Z 2018-10-29T00:17:53Z MEMBER

lgtm

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Allow passing of positional arguments in `apply` for Groupby objects 359449421
421936966 https://github.com/pydata/xarray/pull/2413#issuecomment-421936966 https://api.github.com/repos/pydata/xarray/issues/2413 MDEyOklzc3VlQ29tbWVudDQyMTkzNjk2Ng== maaleske 4414299 2018-09-17T09:08:07Z 2018-09-17T09:08:07Z CONTRIBUTOR

Thanks @spencerkclark, I had almost the exact same code already written but couldn't figure out the return value resample.apply needs from func to work. I added the tests to test_dataarray and test_dataset, since there doesn't appear to be a separate file for resample (as there is for groupby).

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Allow passing of positional arguments in `apply` for Groupby objects 359449421
421853996 https://github.com/pydata/xarray/pull/2413#issuecomment-421853996 https://api.github.com/repos/pydata/xarray/issues/2413 MDEyOklzc3VlQ29tbWVudDQyMTg1Mzk5Ng== spencerkclark 6628425 2018-09-16T23:40:23Z 2018-09-16T23:40:23Z MEMBER

Thanks @maaleske -- following the style of your groupby tests, you could do something like this, e.g. for the DataArray case: ```python def test_da_resample_func_args():

def func(arg1, arg2, arg3=0.):
    return arg1.mean('time') + arg2 + arg3

times = pd.date_range('2000', periods=3, freq='D')
da = xr.DataArray([1., 1., 1.], coords=[times], dims=['time'])
expected = xr.DataArray([3., 3., 3.], coords=[times], dims=['time'])
actual = da.resample(time='D').apply(func, args=(1,), arg3=1)
assert_identical(actual, expected)

```

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Allow passing of positional arguments in `apply` for Groupby objects 359449421
421821689 https://github.com/pydata/xarray/pull/2413#issuecomment-421821689 https://api.github.com/repos/pydata/xarray/issues/2413 MDEyOklzc3VlQ29tbWVudDQyMTgyMTY4OQ== maaleske 4414299 2018-09-16T19:51:44Z 2018-09-16T19:51:44Z CONTRIBUTOR

I added tests for groupby. I haven't used resampling so I'm struggling a bit to make a sensible dataset/array for a similar test of the resample method.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Allow passing of positional arguments in `apply` for Groupby objects 359449421
421664555 https://github.com/pydata/xarray/pull/2413#issuecomment-421664555 https://api.github.com/repos/pydata/xarray/issues/2413 MDEyOklzc3VlQ29tbWVudDQyMTY2NDU1NQ== shoyer 1217238 2018-09-16T01:00:40Z 2018-09-16T01:00:40Z MEMBER

This still needs tests, to verify that this argument works.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Allow passing of positional arguments in `apply` for Groupby objects 359449421
420835954 https://github.com/pydata/xarray/pull/2413#issuecomment-420835954 https://api.github.com/repos/pydata/xarray/issues/2413 MDEyOklzc3VlQ29tbWVudDQyMDgzNTk1NA== shoyer 1217238 2018-09-12T23:51:07Z 2018-09-12T23:51:07Z MEMBER

Looks good to me, thanks!

For consistency, can you update the apply method on the classes in xarray/core/resample.py as well?

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Allow passing of positional arguments in `apply` for Groupby objects 359449421

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);