issue_comments

Table actions

6 rows where issue = 357970488 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: reactions, created_at (date), updated_at (date)

user 2

author_association 2

issue 1

  • Achieving square aspect for Facetgrid heatmaps · 6 ✖
id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
482355829 https://github.com/pydata/xarray/issues/2406#issuecomment-482355829 https://api.github.com/repos/pydata/xarray/issues/2406 MDEyOklzc3VlQ29tbWVudDQ4MjM1NTgyOQ== dcherian 2448579 2019-04-11T22:50:54Z 2019-04-11T22:50:54Z MEMBER

Closing since PR didn't get traction, plot has too many kwargs and it's easy to do this otherwise.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Achieving square aspect for Facetgrid heatmaps 357970488
423810510 https://github.com/pydata/xarray/issues/2406#issuecomment-423810510 https://api.github.com/repos/pydata/xarray/issues/2406 MDEyOklzc3VlQ29tbWVudDQyMzgxMDUxMA== dcherian 2448579 2018-09-23T11:44:44Z 2018-09-23T11:44:44Z MEMBER

In that case, #2427 is ready to review

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Achieving square aspect for Facetgrid heatmaps 357970488
423540830 https://github.com/pydata/xarray/issues/2406#issuecomment-423540830 https://api.github.com/repos/pydata/xarray/issues/2406 MDEyOklzc3VlQ29tbWVudDQyMzU0MDgzMA== jbusecke 14314623 2018-09-21T13:59:52Z 2018-09-21T13:59:52Z CONTRIBUTOR

I would prefer axis_aspect to allow other than square aspects.

 
{
    "total_count": 1,
    "+1": 1,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Achieving square aspect for Facetgrid heatmaps 357970488
423412818 https://github.com/pydata/xarray/issues/2406#issuecomment-423412818 https://api.github.com/repos/pydata/xarray/issues/2406 MDEyOklzc3VlQ29tbWVudDQyMzQxMjgxOA== dcherian 2448579 2018-09-21T04:53:13Z 2018-09-21T04:54:42Z MEMBER

Thoughts on kwarg name?

  1. axis_aspect that is passed on to Axes.set_aspect()
  2. square=True like seaborn
  3. or aspect_square=True
 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Achieving square aspect for Facetgrid heatmaps 357970488
419411028 https://github.com/pydata/xarray/issues/2406#issuecomment-419411028 https://api.github.com/repos/pydata/xarray/issues/2406 MDEyOklzc3VlQ29tbWVudDQxOTQxMTAyOA== jbusecke 14314623 2018-09-07T11:28:09Z 2018-09-07T11:28:09Z CONTRIBUTOR

I like the idea. I would prefer aspect_square=True to be more clear.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Achieving square aspect for Facetgrid heatmaps 357970488
419392903 https://github.com/pydata/xarray/issues/2406#issuecomment-419392903 https://api.github.com/repos/pydata/xarray/issues/2406 MDEyOklzc3VlQ29tbWVudDQxOTM5MjkwMw== dcherian 2448579 2018-09-07T10:14:11Z 2018-09-07T10:14:11Z MEMBER

g = array.plot(x='a', y='b', col='c') [axis.set_aspect('equal') for axis in g.axes.ravel()]

Is this what you want?

I don't know that we need to add square=True as a supported argument but consistency with seaborn could be a good thing I guess. Thoughts?

 
{
    "total_count": 1,
    "+1": 1,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Achieving square aspect for Facetgrid heatmaps 357970488

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);