issue_comments

Table actions

3 rows where issue = 355308699 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: reactions, created_at (date), updated_at (date)

user 3

issue 1

  • Why are there two compute calls for plot? · 3 ✖

author_association 1

id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
417174985 https://github.com/pydata/xarray/issues/2390#issuecomment-417174985 https://api.github.com/repos/pydata/xarray/issues/2390 MDEyOklzc3VlQ29tbWVudDQxNzE3NDk4NQ== shoyer 1217238 2018-08-30T03:07:10Z 2018-08-30T03:07:10Z MEMBER

We should probably call compute() on xarray objects immediately upon entering a plot method. My guess is that this happens because we rely upon coercing with np.asarray() or DataArray.values to get numpy arrays in xarray plotting methods.

 
{
    "total_count": 2,
    "+1": 2,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Why are there two compute calls for plot? 355308699
417097458 https://github.com/pydata/xarray/issues/2390#issuecomment-417097458 https://api.github.com/repos/pydata/xarray/issues/2390 MDEyOklzc3VlQ29tbWVudDQxNzA5NzQ1OA== rabernat 1197350 2018-08-29T20:37:57Z 2018-08-29T20:37:57Z MEMBER

My guess is that this is happening because there is first a call to get the bounds on the data (vmin, vmax).

Does the double compute still happen if you specify vmin and vmax in the call to .plot()?

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Why are there two compute calls for plot? 355308699
417084035 https://github.com/pydata/xarray/issues/2390#issuecomment-417084035 https://api.github.com/repos/pydata/xarray/issues/2390 MDEyOklzc3VlQ29tbWVudDQxNzA4NDAzNQ== mrocklin 306380 2018-08-29T19:54:49Z 2018-08-29T19:54:49Z MEMBER

Sorry, I meant plot.imshow()

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Why are there two compute calls for plot? 355308699

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);