issue_comments

Table actions

6 rows where issue = 353623661 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: created_at (date), updated_at (date)

user 3

author_association 2

issue 1

  • Plotting norm is superseded by xarray vmin and vmax · 6 ✖
id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
425809848 https://github.com/pydata/xarray/issues/2381#issuecomment-425809848 https://api.github.com/repos/pydata/xarray/issues/2381 MDEyOklzc3VlQ29tbWVudDQyNTgwOTg0OA== juseg 1186928 2018-10-01T07:12:13Z 2018-10-01T07:25:47Z CONTRIBUTOR

@dcherian Thanks! This works for me.

I appreciate that my current code using the workaround plot(norm=norm, vmin=norm.vmin, ...) still works. To be fully consistent I suggest to replace the error message Cannot supply vmin and a norm with vmin with Cannot supply vmin and a norm with a different vmin (idem with vmax).

Edit: I just checked that matplotlib's imshow accepts imshow(norm=norm, vmin=vmin, vmax=vmax), with the user-provided vmin taking precedence over the norm. So I'm not sure that xarray need to raise an error here.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Plotting norm is superseded by xarray vmin and vmax 353623661
425397144 https://github.com/pydata/xarray/issues/2381#issuecomment-425397144 https://api.github.com/repos/pydata/xarray/issues/2381 MDEyOklzc3VlQ29tbWVudDQyNTM5NzE0NA== dcherian 2448579 2018-09-28T10:43:09Z 2018-09-28T10:43:09Z MEMBER

@juseg can you take a look at #2443?

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Plotting norm is superseded by xarray vmin and vmax 353623661
418031345 https://github.com/pydata/xarray/issues/2381#issuecomment-418031345 https://api.github.com/repos/pydata/xarray/issues/2381 MDEyOklzc3VlQ29tbWVudDQxODAzMTM0NQ== dcherian 2448579 2018-09-03T07:52:21Z 2018-09-03T07:52:21Z MEMBER

Ooops. Sorry! @juseg 

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Plotting norm is superseded by xarray vmin and vmax 353623661
418026246 https://github.com/pydata/xarray/issues/2381#issuecomment-418026246 https://api.github.com/repos/pydata/xarray/issues/2381 MDEyOklzc3VlQ29tbWVudDQxODAyNjI0Ng== juseg 1186928 2018-09-03T07:30:50Z 2018-09-03T07:30:50Z CONTRIBUTOR

I was working on it but you were quicker, thanks!

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Plotting norm is superseded by xarray vmin and vmax 353623661
417167631 https://github.com/pydata/xarray/issues/2381#issuecomment-417167631 https://api.github.com/repos/pydata/xarray/issues/2381 MDEyOklzc3VlQ29tbWVudDQxNzE2NzYzMQ== dcherian 2448579 2018-08-30T02:20:03Z 2018-08-30T02:20:03Z MEMBER

Yes this looks sensible to me and is an easy fix I think.

@juseg PR welcome! 

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Plotting norm is superseded by xarray vmin and vmax 353623661
416401894 https://github.com/pydata/xarray/issues/2381#issuecomment-416401894 https://api.github.com/repos/pydata/xarray/issues/2381 MDEyOklzc3VlQ29tbWVudDQxNjQwMTg5NA== shoyer 1217238 2018-08-27T23:32:25Z 2018-08-27T23:32:25Z MEMBER

Thanks for bringing this up!

@dcherian @fmaussion I'm going to defer to your judgment here...

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Plotting norm is superseded by xarray vmin and vmax 353623661

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);