issue_comments

Table actions

5 rows where issue = 351343574 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: created_at (date), updated_at (date)

user 3

author_association 2

issue 1

  • `AttributeError: 'DataArray' object has no attribute 'ravel'` when using `np.intersect1d(..., assume_unique=True)` · 5 ✖
id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
431993989 https://github.com/pydata/xarray/issues/2371#issuecomment-431993989 https://api.github.com/repos/pydata/xarray/issues/2371 MDEyOklzc3VlQ29tbWVudDQzMTk5Mzk4OQ== chrisbarber 1530840 2018-10-22T21:27:22Z 2018-10-22T21:27:22Z NONE 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   `AttributeError: 'DataArray' object has no attribute 'ravel'` when using `np.intersect1d(..., assume_unique=True)` 351343574
413967171 https://github.com/pydata/xarray/issues/2371#issuecomment-413967171 https://api.github.com/repos/pydata/xarray/issues/2371 MDEyOklzc3VlQ29tbWVudDQxMzk2NzE3MQ== shoyer 1217238 2018-08-17T19:32:08Z 2018-08-17T19:32:18Z MEMBER

DataArray does not subclass ndarray. It's just a class that implements __array__() but not ravel(). So really np.intersect1d() should just be careful to always call np.asarray() internally, which it was doing before in an implicit way.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   `AttributeError: 'DataArray' object has no attribute 'ravel'` when using `np.intersect1d(..., assume_unique=True)` 351343574
413966744 https://github.com/pydata/xarray/issues/2371#issuecomment-413966744 https://api.github.com/repos/pydata/xarray/issues/2371 MDEyOklzc3VlQ29tbWVudDQxMzk2Njc0NA== charris 77272 2018-08-17T19:30:09Z 2018-08-17T19:30:09Z NONE

I'm also curious if DataArray supports the common indices enhancement that led to this problem.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   `AttributeError: 'DataArray' object has no attribute 'ravel'` when using `np.intersect1d(..., assume_unique=True)` 351343574
413966327 https://github.com/pydata/xarray/issues/2371#issuecomment-413966327 https://api.github.com/repos/pydata/xarray/issues/2371 MDEyOklzc3VlQ29tbWVudDQxMzk2NjMyNw== charris 77272 2018-08-17T19:28:23Z 2018-08-17T19:28:23Z NONE

@shoyer Does DataArray subclass ndarray? We can make some fixes in NumPy, but I'd like to know what we are trying to support here. In particular, we should have a test for anything we decide needs to be supported into the future, and this sounds a bit like a special case.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   `AttributeError: 'DataArray' object has no attribute 'ravel'` when using `np.intersect1d(..., assume_unique=True)` 351343574
413724685 https://github.com/pydata/xarray/issues/2371#issuecomment-413724685 https://api.github.com/repos/pydata/xarray/issues/2371 MDEyOklzc3VlQ29tbWVudDQxMzcyNDY4NQ== shoyer 1217238 2018-08-17T00:41:53Z 2018-08-17T00:41:53Z MEMBER

It looks like this changed in NumPy 1.15 which changed intersect1d -- could you kindly report the bug upstream?

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   `AttributeError: 'DataArray' object has no attribute 'ravel'` when using `np.intersect1d(..., assume_unique=True)` 351343574

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);