issue_comments

Table actions

2 rows where issue = 344058811 and user = 10050469 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: created_at (date), updated_at (date)

user 1

  • fmaussion · 2 ✖

issue 1

  • Proposal: Update rasterio backend to store CRS/nodata information in standard locations. · 2 ✖

author_association 1

id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
408016722 https://github.com/pydata/xarray/issues/2308#issuecomment-408016722 https://api.github.com/repos/pydata/xarray/issues/2308 MDEyOklzc3VlQ29tbWVudDQwODAxNjcyMg== fmaussion 10050469 2018-07-26T08:19:29Z 2018-07-26T08:19:29Z MEMBER

I'm going to leave this decision to @shoyer and @jhamman !

If we go forward with this, we have a couple of possibilities:

  1. add crs to a coordinate variable and keep the attribute too (not so nice because doubled)
  2. add crs to a coordinate variable and deprecate the crs attribute

Same with _FillValue.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Proposal: Update rasterio backend to store CRS/nodata information in standard locations. 344058811
407684501 https://github.com/pydata/xarray/issues/2308#issuecomment-407684501 https://api.github.com/repos/pydata/xarray/issues/2308 MDEyOklzc3VlQ29tbWVudDQwNzY4NDUwMQ== fmaussion 10050469 2018-07-25T08:58:31Z 2018-07-25T08:58:31Z MEMBER

Again, I'm yet to be convinced that this logic should live in xarray, regardless if netCDF or rasterio is used as a backend. The job of xarray is to read the rasterio files in a "xarray way" (e.g. in order to leverage dask) and exposing the file attributes to the user, ideally with semantics/attribute names which are as close as possible as the underlying data model (rasterio).

All the logic you describe could live in a dedicated library which would become a wrapper around xarray's open_* functions, and converting them to the format you describe. 

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Proposal: Update rasterio backend to store CRS/nodata information in standard locations. 344058811

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);