issue_comments

Table actions

4 rows where issue = 342793201 and user = 6628425 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: created_at (date), updated_at (date)

user 1

  • spencerkclark · 4 ✖

issue 1

  • WIP Add a CFTimeIndex-enabled xr.cftime_range function · 4 ✖

author_association 1

id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
421467827 https://github.com/pydata/xarray/pull/2301#issuecomment-421467827 https://api.github.com/repos/pydata/xarray/issues/2301 MDEyOklzc3VlQ29tbWVudDQyMTQ2NzgyNw== spencerkclark 6628425 2018-09-14T19:56:14Z 2018-09-14T19:56:14Z MEMBER

Many thanks for the initial review @shoyer. I think I got to everything so far. I agree restricting cftime_range to only return CFTimeIndexes makes things much simpler to reason about.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   WIP Add a CFTimeIndex-enabled xr.cftime_range function 342793201
417858978 https://github.com/pydata/xarray/pull/2301#issuecomment-417858978 https://api.github.com/repos/pydata/xarray/issues/2301 MDEyOklzc3VlQ29tbWVudDQxNzg1ODk3OA== spencerkclark 6628425 2018-09-01T13:15:34Z 2018-09-01T13:15:34Z MEMBER

Awesome, thanks @shoyer.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   WIP Add a CFTimeIndex-enabled xr.cftime_range function 342793201
417436579 https://github.com/pydata/xarray/pull/2301#issuecomment-417436579 https://api.github.com/repos/pydata/xarray/issues/2301 MDEyOklzc3VlQ29tbWVudDQxNzQzNjU3OQ== spencerkclark 6628425 2018-08-30T19:20:11Z 2018-08-30T19:20:11Z MEMBER

Thanks @jhamman! This should be synced up and ready for review. The test failure under the dask-dev build doesn't appear to be related.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   WIP Add a CFTimeIndex-enabled xr.cftime_range function 342793201
406894349 https://github.com/pydata/xarray/pull/2301#issuecomment-406894349 https://api.github.com/repos/pydata/xarray/issues/2301 MDEyOklzc3VlQ29tbWVudDQwNjg5NDM0OQ== spencerkclark 6628425 2018-07-22T20:28:09Z 2018-07-22T20:28:09Z MEMBER

@jhamman @shoyer when you get a chance, I think this is ready for review.

I did a few more things since first pushing this PR: - Previously CFTimeIndex would raise an error if it contained an empty array; I'm not really sure what the use case would be, but to be consistent with the way DatetimeIndex behaves, I made modifications to allow for this (in some cases date_range returns an empty index). I also added the ability to give a CFTimeIndex a name. - The repr of CFTimeIndex previously provided no information regarding the calendar type of the index; I found this somewhat inconvenient, so I added a custom __unicode__ method to CFTimeIndex, which pandas.Index uses to build its repr. I think the result looks decent (I updated the examples above), but the implementation is a bit crude (relying on a number of private API functions of the base Index class). Maybe there is a better way or maybe we should put this off until later? - I added arguments to the constructor for CFTimeIndex that makes it more analogous to the constructor for a DatetimeIndex, allowing one to either pass dates directly, or create dates using arguments one can pass to date_range (inspired by https://github.com/pydata/xarray/issues/2140#issuecomment-389590577).

I hope the general approach seems reasonable, though if you had something else in mind for how to implement this originally, I'd be open to changing things. I tried to keep things as basic as I could (the pandas date_range function is fairly involved!). 

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   WIP Add a CFTimeIndex-enabled xr.cftime_range function 342793201

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);