home / github

Menu
  • GraphQL API
  • Search all tables

issue_comments

Table actions
  • GraphQL API for issue_comments

6 rows where issue = 341321742 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: created_at (date), updated_at (date)

user 4

  • shoyer 2
  • fmaussion 2
  • y3nr1ng 1
  • pep8speaks 1

author_association 2

  • MEMBER 4
  • NONE 2

issue 1

  • ENH: Adapt scipy example to imageio · 6 ✖
id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
519780523 https://github.com/pydata/xarray/pull/2287#issuecomment-519780523 https://api.github.com/repos/pydata/xarray/issues/2287 MDEyOklzc3VlQ29tbWVudDUxOTc4MDUyMw== pep8speaks 24736507 2019-08-09T05:11:39Z 2019-08-09T05:11:39Z NONE

Hello @liuyenting! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

  • In the file xarray/backends/imageio.py:

Line 22:48: W504 line break after binary operator Line 136:13: E265 block comment should start with '# '

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
  ENH: Adapt scipy example to imageio 341321742
405414950 https://github.com/pydata/xarray/pull/2287#issuecomment-405414950 https://api.github.com/repos/pydata/xarray/issues/2287 MDEyOklzc3VlQ29tbWVudDQwNTQxNDk1MA== shoyer 1217238 2018-07-16T23:49:02Z 2018-07-16T23:49:02Z MEMBER

OK, maybe this would indeed be an appropriate approach if you want to support writing files with our current interface. Unfortunately, our current interface is indeed very inadequate for such use-cases -- as you have no-doubt noticed! This is on our soon to be published roadmap to fix, but it will be a longer process.

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
  ENH: Adapt scipy example to imageio 341321742
405304149 https://github.com/pydata/xarray/pull/2287#issuecomment-405304149 https://api.github.com/repos/pydata/xarray/issues/2287 MDEyOklzc3VlQ29tbWVudDQwNTMwNDE0OQ== fmaussion 10050469 2018-07-16T16:22:42Z 2018-07-16T16:22:42Z MEMBER

Generally, image containers opened by imageio represents a single Dataset only, which is why I default names to their readout sequences. However, there are indeed cases where multiple variables exist, such as pyramids of image sequences, each pyramid layer represents a different resolution for the sequence.

Can you show some examples of how imageio works: - in the case of a single array - in the case of multiple variables ?

However, it is my understanding, and please correct me if I am wrong, that rasterio backend is aimed at being a read-only I/O for xarray without having the extensibility for write ability, and I'm really eager to keep the ability to aggregate multiple files through dask, as well as saving data through imageio transparently (if plausible) :p

This can be done regardless. You can add open_imageio and to_imageio methods to DataArrays/Datasets without the existing abstractions which were written for NetCDF-like files.

Do you already have an idea of how the to_imageio API would look like? This looks quite a complex topic...

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
  ENH: Adapt scipy example to imageio 341321742
405293927 https://github.com/pydata/xarray/pull/2287#issuecomment-405293927 https://api.github.com/repos/pydata/xarray/issues/2287 MDEyOklzc3VlQ29tbWVudDQwNTI5MzkyNw== y3nr1ng 2089799 2018-07-16T15:50:48Z 2018-07-16T16:10:09Z NONE

if xarray's rasterio backend wouldn't be a better template for an imageio backend instead.

I started with rasterio in the beginning, since TIFF-like containers are not modifiable, cache is crucial. However, it is my understanding, and please correct me if I am wrong, that rasterio backend is aimed at being a read-only I/O for xarray without having the extensibility for write ability, and I'm really eager to keep the ability to aggregate multiple files through dask, as well as saving data through imageio transparently (if plausible) :p

On second thought, maybe open_rasterio type of approach with to_zarr for saving is more preferable? But what are the possible approaches for open_mfdataset (and the potential of using dask for out-of-memory file I/O)?

For example, can imageio open any file which resembles a Dataset (i.e.: more than one variable with different datatypes), or would a DataArray be enough?

Generally, image containers opened by imageio represents a single Dataset only, which is why I default names to their readout sequences. However, there are indeed cases where multiple variables exist, such as pyramids of image sequences, each pyramid layer represents a different resolution for the sequence.

I must admit that a single DataArray is more applicable to the general usage.

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
  ENH: Adapt scipy example to imageio 341321742
405288100 https://github.com/pydata/xarray/pull/2287#issuecomment-405288100 https://api.github.com/repos/pydata/xarray/issues/2287 MDEyOklzc3VlQ29tbWVudDQwNTI4ODEwMA== shoyer 1217238 2018-07-16T15:33:24Z 2018-07-16T15:33:24Z MEMBER

Yes, I would recommend taking a look at open_rasterio() for an example of reading image files. The other backend examples map much more closely to the netCDF data model.

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
  ENH: Adapt scipy example to imageio 341321742
405106658 https://github.com/pydata/xarray/pull/2287#issuecomment-405106658 https://api.github.com/repos/pydata/xarray/issues/2287 MDEyOklzc3VlQ29tbWVudDQwNTEwNjY1OA== fmaussion 10050469 2018-07-15T17:46:32Z 2018-07-15T17:46:32Z MEMBER

Thanks! Without looking into too much detail (yet), I think it would be a great addition!

Correct me if I'm wrong, but I wonder if xarray's rasterio backend wouldn't be a better template for an imageio backend instead. For example, can imageio open any file which resembles a Dataset (i.e.: more than one variable with different datatypes), or would a DataArray be enough?

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
  ENH: Adapt scipy example to imageio 341321742

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options:

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);
Powered by Datasette · Queries took 191.815ms · About: xarray-datasette