issue_comments

Table actions

6 rows where issue = 33852501 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: created_at (date), updated_at (date)

user 2

issue 1

  • Dataset.reduce methods · 6 ✖

author_association 1

id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
43809030 https://github.com/pydata/xarray/pull/137#issuecomment-43809030 https://api.github.com/repos/pydata/xarray/issues/137 MDEyOklzc3VlQ29tbWVudDQzODA5MDMw shoyer 1217238 2014-05-21T20:23:42Z 2014-05-21T20:23:42Z MEMBER

Thanks!

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Dataset.reduce methods 33852501
43807861 https://github.com/pydata/xarray/pull/137#issuecomment-43807861 https://api.github.com/repos/pydata/xarray/issues/137 MDEyOklzc3VlQ29tbWVudDQzODA3ODYx jhamman 2443309 2014-05-21T20:13:33Z 2014-05-21T20:13:33Z MEMBER

Alright, the rebase/squash is done. 

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Dataset.reduce methods 33852501
43806352 https://github.com/pydata/xarray/pull/137#issuecomment-43806352 https://api.github.com/repos/pydata/xarray/issues/137 MDEyOklzc3VlQ29tbWVudDQzODA2MzUy shoyer 1217238 2014-05-21T19:59:28Z 2014-05-21T19:59:28Z MEMBER

OK, this looks good to me now! Since the history is a little messy (given the number of revisions) could you please squash this into a single commit when I can merge?

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Dataset.reduce methods 33852501
43717004 https://github.com/pydata/xarray/pull/137#issuecomment-43717004 https://api.github.com/repos/pydata/xarray/issues/137 MDEyOklzc3VlQ29tbWVudDQzNzE3MDA0 jhamman 2443309 2014-05-21T06:37:11Z 2014-05-21T06:37:11Z MEMBER

@shoyer - re. the two tests you requested.
- See test_reduce_bad_dimension in test_dataset.py. - see test_reduce_non_numeric in test_dataset.py.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Dataset.reduce methods 33852501
43711110 https://github.com/pydata/xarray/pull/137#issuecomment-43711110 https://api.github.com/repos/pydata/xarray/issues/137 MDEyOklzc3VlQ29tbWVudDQzNzExMTEw shoyer 1217238 2014-05-21T04:25:10Z 2014-05-21T04:25:10Z MEMBER

This getting pretty close but I would like more comprehensive tests to be confident that it is working properly: - Verify an exception is raised if a bad dimension is supplied. - Verify that arrays with non-numeric data types are skipped if doing an inappropriate reduction (e.g., mean of a string variable).

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Dataset.reduce methods 33852501
43585330 https://github.com/pydata/xarray/pull/137#issuecomment-43585330 https://api.github.com/repos/pydata/xarray/issues/137 MDEyOklzc3VlQ29tbWVudDQzNTg1MzMw shoyer 1217238 2014-05-20T04:27:14Z 2014-05-20T04:27:14Z MEMBER

Very nice start! Please also add a try/except TypeError block to skip variables where the reduction isn't well defined.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Dataset.reduce methods 33852501

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);