issue_comments

Table actions

4 rows where issue = 334833619 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: created_at (date), updated_at (date)

user 4

author_association 2

issue 1

  • Attributes of Dataset coordinates are dropped/replaced when adding a DataArray · 4 ✖
id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
1029157038 https://github.com/pydata/xarray/issues/2245#issuecomment-1029157038 https://api.github.com/repos/pydata/xarray/issues/2245 IC_kwDOAMm_X849V7Cu leonfoks 15173535 2022-02-03T16:18:14Z 2022-02-03T16:18:14Z NONE

Encountered this issue this week, is there anything in the works to address this?

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Attributes of Dataset coordinates are dropped/replaced when adding a DataArray 334833619
525549536 https://github.com/pydata/xarray/issues/2245#issuecomment-525549536 https://api.github.com/repos/pydata/xarray/issues/2245 MDEyOklzc3VlQ29tbWVudDUyNTU0OTUzNg== wtgee 70736 2019-08-28T01:48:14Z 2019-08-28T02:00:30Z NONE

~~Was there ever a solution here? I'm opening multiple netCDF files via open_mfdataset but the attrs get clobbered since they all have the same keys.~~

Edit: I was thinking about it a little wrong although I can still see a use case. 

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Attributes of Dataset coordinates are dropped/replaced when adding a DataArray 334833619
406959556 https://github.com/pydata/xarray/issues/2245#issuecomment-406959556 https://api.github.com/repos/pydata/xarray/issues/2245 MDEyOklzc3VlQ29tbWVudDQwNjk1OTU1Ng== dcherian 2448579 2018-07-23T07:01:07Z 2018-07-23T07:01:28Z MEMBER

This is because priority_arg=1 in https://github.com/pydata/xarray/blob/b8a342ae845a7d734d391c4b597ee689ed9c6a72/xarray/core/merge.py#L579

So the old co-ordinate (with attrs) is replaced by the new co-ordinate (without attrs).

Example: ds['b'] = xr.DataArray(np.arange(10), dims='y') in the above creates a new dimension y with no attrs that is given priority when merging. This seems like intended behaviour because changing priority_arg to 0 makes a lot of tests fail.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Attributes of Dataset coordinates are dropped/replaced when adding a DataArray 334833619
403934444 https://github.com/pydata/xarray/issues/2245#issuecomment-403934444 https://api.github.com/repos/pydata/xarray/issues/2245 MDEyOklzc3VlQ29tbWVudDQwMzkzNDQ0NA== shoyer 1217238 2018-07-10T19:11:12Z 2018-07-10T19:11:12Z MEMBER

This looks like the same issue as https://github.com/pydata/xarray/issues/2276.

I agree that this is probably a bug. This might be related to a recent internal refactor of Dataset.__setitem__ in https://github.com/pydata/xarray/pull/2162 (see the changes in xarray/core/merge.py)

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Attributes of Dataset coordinates are dropped/replaced when adding a DataArray 334833619

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);