issue_comments

Table actions

6 rows where issue = 33396232 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: created_at (date), updated_at (date)

user 2

author_association 2

issue 1

  • initial implementation of support for NetCDF groups · 6 ✖
id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
43385302 https://github.com/pydata/xarray/pull/127#issuecomment-43385302 https://api.github.com/repos/pydata/xarray/issues/127 MDEyOklzc3VlQ29tbWVudDQzMzg1MzAy alimanfoo 703554 2014-05-16T22:16:01Z 2014-05-16T22:16:01Z CONTRIBUTOR

No worries, glad to contribute.

On Friday, 16 May 2014, Stephan Hoyer notifications@github.com wrote:

Thanks @alimanfoo https://github.com/alimanfoo!

Reply to this email directly or view it on GitHubhttps://github.com/xray-pydata/xray/pull/127#issuecomment-43287303 .

Alistair Miles Head of Epidemiological Informatics Centre for Genomics and Global Health http://cggh.org The Wellcome Trust Centre for Human Genetics Roosevelt Drive Oxford OX3 7BN United Kingdom Web: http://purl.org/net/aliman Email: alimanfoo@gmail.com Tel: +44 (0)1865 287721 _new number_

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   initial implementation of support for NetCDF groups 33396232
43287303 https://github.com/pydata/xarray/pull/127#issuecomment-43287303 https://api.github.com/repos/pydata/xarray/issues/127 MDEyOklzc3VlQ29tbWVudDQzMjg3MzAz shoyer 1217238 2014-05-16T01:46:27Z 2014-05-16T01:46:27Z MEMBER

Thanks @alimanfoo!

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   initial implementation of support for NetCDF groups 33396232
43059199 https://github.com/pydata/xarray/pull/127#issuecomment-43059199 https://api.github.com/repos/pydata/xarray/issues/127 MDEyOklzc3VlQ29tbWVudDQzMDU5MTk5 alimanfoo 703554 2014-05-14T09:20:01Z 2014-05-14T09:20:01Z CONTRIBUTOR

I've added a test to check for an error when a group is not found. I also changed the implementation of the group access function to avoid recursion, it seemed simpler.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   initial implementation of support for NetCDF groups 33396232
43025772 https://github.com/pydata/xarray/pull/127#issuecomment-43025772 https://api.github.com/repos/pydata/xarray/issues/127 MDEyOklzc3VlQ29tbWVudDQzMDI1Nzcy shoyer 1217238 2014-05-13T23:26:36Z 2014-05-13T23:26:36Z MEMBER

One last thing: could you add a test to check for the IOError when given an invalid group?

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   initial implementation of support for NetCDF groups 33396232
43024743 https://github.com/pydata/xarray/pull/127#issuecomment-43024743 https://api.github.com/repos/pydata/xarray/issues/127 MDEyOklzc3VlQ29tbWVudDQzMDI0NzQz alimanfoo 703554 2014-05-13T23:11:07Z 2014-05-13T23:11:07Z CONTRIBUTOR

Thanks for the comments, all makes good sense.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   initial implementation of support for NetCDF groups 33396232
42987555 https://github.com/pydata/xarray/pull/127#issuecomment-42987555 https://api.github.com/repos/pydata/xarray/issues/127 MDEyOklzc3VlQ29tbWVudDQyOTg3NTU1 shoyer 1217238 2014-05-13T17:42:14Z 2014-05-13T17:42:14Z MEMBER

Very nice! I have a few minor issues but this looks nearly good to go.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   initial implementation of support for NetCDF groups 33396232

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);