issue_comments

Table actions

5 rows where issue = 333480301 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: reactions, created_at (date), updated_at (date)

user 3

issue 1

  • Failing test with dask_distributed · 5 ✖

author_association 1

id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
398919584 https://github.com/pydata/xarray/issues/2238#issuecomment-398919584 https://api.github.com/repos/pydata/xarray/issues/2238 MDEyOklzc3VlQ29tbWVudDM5ODkxOTU4NA== shoyer 1217238 2018-06-20T22:36:50Z 2018-06-20T22:36:50Z MEMBER

@jhamman sounds good! it would be also be good to xfail the failing tests with dask 0.18.0

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Failing test with dask_distributed 333480301
398918501 https://github.com/pydata/xarray/issues/2238#issuecomment-398918501 https://api.github.com/repos/pydata/xarray/issues/2238 MDEyOklzc3VlQ29tbWVudDM5ODkxODUwMQ== jhamman 2443309 2018-06-20T22:31:46Z 2018-06-20T22:31:46Z MEMBER

Thanks folks for sorting this out while I was away. I'm happy to take on switching to dask's get_scheduler.

 
{
    "total_count": 1,
    "+1": 1,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Failing test with dask_distributed 333480301
398500088 https://github.com/pydata/xarray/issues/2238#issuecomment-398500088 https://api.github.com/repos/pydata/xarray/issues/2238 MDEyOklzc3VlQ29tbWVudDM5ODUwMDA4OA== mrocklin 306380 2018-06-19T18:31:04Z 2018-06-19T18:31:04Z MEMBER

We can add this back in. I anticipate having to do a bugfix release within a week or two. Long term you probably want to do the following:

python from dask.utils import get_scheduler actual_get = get_scheduler(get=get, collections=[collection]) 

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Failing test with dask_distributed 333480301
398494878 https://github.com/pydata/xarray/issues/2238#issuecomment-398494878 https://api.github.com/repos/pydata/xarray/issues/2238 MDEyOklzc3VlQ29tbWVudDM5ODQ5NDg3OA== shoyer 1217238 2018-06-19T18:14:41Z 2018-06-19T18:14:41Z MEMBER

This import no longer works: from dask.utils import effective_get

I'm raising an issue in the dask tracker...

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Failing test with dask_distributed 333480301
398239960 https://github.com/pydata/xarray/issues/2238#issuecomment-398239960 https://api.github.com/repos/pydata/xarray/issues/2238 MDEyOklzc3VlQ29tbWVudDM5ODIzOTk2MA== shoyer 1217238 2018-06-19T00:52:06Z 2018-06-19T00:52:06Z MEMBER

My best guess is that our logic for getting the default scheduler and/or lock is failing with the latest dask release (0.18): https://github.com/pydata/xarray/blob/66be9c5db7d86ea385c3a4cd4295bfce67e3f25b/xarray/backends/common.py#L34-L81

Perhaps @jhamman can take a look?

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Failing test with dask_distributed 333480301

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);