issue_comments

Table actions

6 rows where issue = 327893262 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: reactions, created_at (date), updated_at (date)

user 3

issue 1

  • Update minimum version of dask · 6 ✖

author_association 1

id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
393401980 https://github.com/pydata/xarray/issues/2203#issuecomment-393401980 https://api.github.com/repos/pydata/xarray/issues/2203 MDEyOklzc3VlQ29tbWVudDM5MzQwMTk4MA== shoyer 1217238 2018-05-31T04:55:00Z 2018-05-31T04:55:00Z MEMBER

The policy I've tried to keep to is keeping everything working with base supported version, but we can add new features that rely on new dask features. On Wed, May 30, 2018 at 8:20 PM Keisuke Fujii notifications@github.com wrote:

How do we consider the minimum version of optional dependency? If we say "the minimum version of dask is 0.16", then all our dask related functions should work with dask=0.16? or do we allow functions that only work with newer version of dask if we raise an appropriate error message?

— You are receiving this because you are on a team that was mentioned. Reply to this email directly, view it on GitHub https://github.com/pydata/xarray/issues/2203#issuecomment-393389052, or mute the thread https://github.com/notifications/unsubscribe-auth/ABKS1uTxKa_GJxvqVj2H2LvL-IYTOCWPks5t32FugaJpZM4UT_GD . 

{
    "total_count": 1,
    "+1": 1,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Update minimum version of dask 327893262
393389052 https://github.com/pydata/xarray/issues/2203#issuecomment-393389052 https://api.github.com/repos/pydata/xarray/issues/2203 MDEyOklzc3VlQ29tbWVudDM5MzM4OTA1Mg== fujiisoup 6815844 2018-05-31T03:20:13Z 2018-05-31T03:20:13Z MEMBER

How do we consider the minimum version of optional dependency? If we say "the minimum version of dask is 0.16", then all our dask related functions should work with dask=0.16? or do we allow functions that only work with newer version of dask if we raise an appropriate error message?

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Update minimum version of dask 327893262
393335578 https://github.com/pydata/xarray/issues/2203#issuecomment-393335578 https://api.github.com/repos/pydata/xarray/issues/2203 MDEyOklzc3VlQ29tbWVudDM5MzMzNTU3OA== fujiisoup 6815844 2018-05-30T22:07:52Z 2018-05-31T02:42:22Z MEMBER

DataArray.dot() is using dask.einsum, and it only woks with dask >= 0.17.5 (#2089).

Does this requirement sound is too strict? If so, it maybe better to add another pass for older dask.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Update minimum version of dask 327893262
393361676 https://github.com/pydata/xarray/issues/2203#issuecomment-393361676 https://api.github.com/repos/pydata/xarray/issues/2203 MDEyOklzc3VlQ29tbWVudDM5MzM2MTY3Ng== jhamman 2443309 2018-05-31T00:25:15Z 2018-05-31T00:25:15Z MEMBER

Can I update my recommendation to 0.16? That is the version that added the new collection interface.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Update minimum version of dask 327893262
393357662 https://github.com/pydata/xarray/issues/2203#issuecomment-393357662 https://api.github.com/repos/pydata/xarray/issues/2203 MDEyOklzc3VlQ29tbWVudDM5MzM1NzY2Mg== shoyer 1217238 2018-05-31T00:02:01Z 2018-05-31T00:02:08Z MEMBER

Requiring 0.15.4 seems reasonable to me. There is virtue in supporting a (small) range of versions in dependencies. But clearly 0.9 was too out of date here.

We should probably add a CI test against the oldest version of dask that we support, just to make sure things don't sneak through.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Update minimum version of dask 327893262
393355654 https://github.com/pydata/xarray/issues/2203#issuecomment-393355654 https://api.github.com/repos/pydata/xarray/issues/2203 MDEyOklzc3VlQ29tbWVudDM5MzM1NTY1NA== jhamman 2443309 2018-05-30T23:52:14Z 2018-05-30T23:52:14Z MEMBER

We have traditionally allowed for a fairly large lag in version dependencies so I'd guess that 0.17.5 (May 16, 2018) is too recent. That said, I'm in favor of shrinking that window to facilitate faster integration of new features.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Update minimum version of dask 327893262

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);