issue_comments

Table actions

6 rows where issue = 324099923 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: created_at (date), updated_at (date)

user 4

author_association 2

issue 1

  • Plot labels use CF convention information if available. · 6 ✖
id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
394026140 https://github.com/pydata/xarray/pull/2151#issuecomment-394026140 https://api.github.com/repos/pydata/xarray/issues/2151 MDEyOklzc3VlQ29tbWVudDM5NDAyNjE0MA== shoyer 1217238 2018-06-01T22:30:05Z 2018-06-01T22:30:05Z MEMBER

OK, I think this is ready to merge. Anyone else have concerns?

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Plot labels use CF convention information if available. 324099923
393947061 https://github.com/pydata/xarray/pull/2151#issuecomment-393947061 https://api.github.com/repos/pydata/xarray/issues/2151 MDEyOklzc3VlQ29tbWVudDM5Mzk0NzA2MQ== dcherian 2448579 2018-06-01T17:12:16Z 2018-06-01T17:12:16Z MEMBER

Rebased on master and updated based on review comments.

I haven't used pytest.mark.parameterize because I found it a little confusing.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Plot labels use CF convention information if available. 324099923
390513494 https://github.com/pydata/xarray/pull/2151#issuecomment-390513494 https://api.github.com/repos/pydata/xarray/issues/2151 MDEyOklzc3VlQ29tbWVudDM5MDUxMzQ5NA== jbusecke 14314623 2018-05-20T21:17:51Z 2018-05-20T21:17:51Z CONTRIBUTOR

This looks good to me! thanks for the implementation! This will save lots of seconds that add up ;-)

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Plot labels use CF convention information if available. 324099923
390510128 https://github.com/pydata/xarray/pull/2151#issuecomment-390510128 https://api.github.com/repos/pydata/xarray/issues/2151 MDEyOklzc3VlQ29tbWVudDM5MDUxMDEyOA== rabernat 1197350 2018-05-20T20:31:17Z 2018-05-20T20:31:17Z MEMBER

Anyone else have thoughts on this? @Zac-HD, @fmaussion, @fujiisoup, and @jbusecke have all contributed to those earlier discussions / PRs.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Plot labels use CF convention information if available. 324099923
390002274 https://github.com/pydata/xarray/pull/2151#issuecomment-390002274 https://api.github.com/repos/pydata/xarray/issues/2151 MDEyOklzc3VlQ29tbWVudDM5MDAwMjI3NA== dcherian 2448579 2018-05-17T20:34:54Z 2018-05-17T20:34:54Z MEMBER

Do we want to have a way to disable this new feature and revert back to old behavior?

I can add an option if needed.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Plot labels use CF convention information if available. 324099923
389931403 https://github.com/pydata/xarray/pull/2151#issuecomment-389931403 https://api.github.com/repos/pydata/xarray/issues/2151 MDEyOklzc3VlQ29tbWVudDM4OTkzMTQwMw== dcherian 2448579 2018-05-17T16:40:04Z 2018-05-17T16:40:14Z MEMBER

The units in the images (which are from the docs) say "deg K" but really should be "deg C". I've fixed that

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Plot labels use CF convention information if available. 324099923

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);