issue_comments

Table actions

3 rows where issue = 324040111 and user = 6213168 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: created_at (date), updated_at (date)

user 1

  • crusaderky · 3 ✖

issue 1

  • [REGRESSION] to_netcdf doesn't accept dtype=S1 encoding anymore · 3 ✖

author_association 1

id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
389954770 https://github.com/pydata/xarray/issues/2149#issuecomment-389954770 https://api.github.com/repos/pydata/xarray/issues/2149 MDEyOklzc3VlQ29tbWVudDM4OTk1NDc3MA== crusaderky 6213168 2018-05-17T17:57:07Z 2018-05-17T17:57:07Z MEMBER

@shoyer I'm struggling to understand your change - help would be appreciated.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   [REGRESSION] to_netcdf doesn't accept dtype=S1 encoding anymore 324040111
389947329 https://github.com/pydata/xarray/issues/2149#issuecomment-389947329 https://api.github.com/repos/pydata/xarray/issues/2149 MDEyOklzc3VlQ29tbWVudDM4OTk0NzMyOQ== crusaderky 6213168 2018-05-17T17:33:06Z 2018-05-17T17:33:37Z MEMBER

@shoyer found the culprit: https://github.com/pydata/xarray/commit/3c8935e537e6ec05a83dbe372bfe45d88308d665 Still need to understand why if you set the encoding directly on the variable it works though.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   [REGRESSION] to_netcdf doesn't accept dtype=S1 encoding anymore 324040111
389885258 https://github.com/pydata/xarray/issues/2149#issuecomment-389885258 https://api.github.com/repos/pydata/xarray/issues/2149 MDEyOklzc3VlQ29tbWVudDM4OTg4NTI1OA== crusaderky 6213168 2018-05-17T14:25:24Z 2018-05-17T14:25:24Z MEMBER
  1. this is limited to dtype=S1. There's auto tests implemented for dtype=f4 and dtype=int16 (https://github.com/pydata/xarray/blob/master/xarray/tests/test_backends.py#L729-L756), and those work fine. ds = xarray.Dataset({'x': [1, 2]}) ds.to_netcdf('test.nc', encoding={'x': {'dtype': 'f4'}})
  2. the bug can be worked around by setting the dtype on the variable directly - for which there is an automated test specific for S1 (https://github.com/pydata/xarray/blob/master/xarray/tests/test_backends.py#L333-L343): ds = xarray.Dataset({'x': ['foo', 'bar', 'baz']}) ds['x'].encoding['dtype'] = 'S1' ds.to_netcdf('test.nc')
 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   [REGRESSION] to_netcdf doesn't accept dtype=S1 encoding anymore 324040111

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);