issue_comments

Table actions

13 rows where issue = 323823894 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: reactions, created_at (date), updated_at (date)

author_association 2

issue 1

  • Add strftime() to datetime accessor · 13 ✖
id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
496036760 https://github.com/pydata/xarray/pull/2144#issuecomment-496036760 https://api.github.com/repos/pydata/xarray/issues/2144 MDEyOklzc3VlQ29tbWVudDQ5NjAzNjc2MA== abrammer 6145107 2019-05-26T22:32:29Z 2019-05-26T22:32:29Z CONTRIBUTOR

@dopplershift I built from your start here, over in #2989 and keeping your initial code and tests along with an edited version of your what's-new. Kept you in the what's new, so hope that's cool otherwise lmk. 

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Add strftime() to datetime accessor 323823894
495770271 https://github.com/pydata/xarray/pull/2144#issuecomment-495770271 https://api.github.com/repos/pydata/xarray/issues/2144 MDEyOklzc3VlQ29tbWVudDQ5NTc3MDI3MQ== dopplershift 221526 2019-05-24T19:56:21Z 2019-05-24T19:56:21Z CONTRIBUTOR

So I finally have time to work on this...but if someone has working code to do this instead, I'm totally fine with that going in instead.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Add strftime() to datetime accessor 323823894
495737434 https://github.com/pydata/xarray/pull/2144#issuecomment-495737434 https://api.github.com/repos/pydata/xarray/issues/2144 MDEyOklzc3VlQ29tbWVudDQ5NTczNzQzNA== jhamman 2443309 2019-05-24T18:10:49Z 2019-05-24T18:10:49Z MEMBER

@abrammer - please go ahead and open a PR. We can leave this open in the meantime. Thanks! 

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Add strftime() to datetime accessor 323823894
495723917 https://github.com/pydata/xarray/pull/2144#issuecomment-495723917 https://api.github.com/repos/pydata/xarray/issues/2144 MDEyOklzc3VlQ29tbWVudDQ5NTcyMzkxNw== abrammer 6145107 2019-05-24T17:35:59Z 2019-05-24T17:35:59Z CONTRIBUTOR

I took a stab at this after being reminded about it. https://github.com/abrammer/xarray/tree/strftime_addition Can open a new PR if this one has gone stale. 

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Add strftime() to datetime accessor 323823894
495243705 https://github.com/pydata/xarray/pull/2144#issuecomment-495243705 https://api.github.com/repos/pydata/xarray/issues/2144 MDEyOklzc3VlQ29tbWVudDQ5NTI0MzcwNQ== max-sixty 5635139 2019-05-23T14:31:01Z 2019-05-23T14:31:01Z MEMBER

Given we're ~a year since the last commit and @dopplershift has taken this so far, @dopplershift are you OK if someone takes this to the finish line?

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Add strftime() to datetime accessor 323823894
495069997 https://github.com/pydata/xarray/pull/2144#issuecomment-495069997 https://api.github.com/repos/pydata/xarray/issues/2144 MDEyOklzc3VlQ29tbWVudDQ5NTA2OTk5Nw== ahuang11 15331990 2019-05-23T05:13:46Z 2019-05-23T05:13:46Z CONTRIBUTOR

Would also like to see this move forward and would be happy to help if needed.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Add strftime() to datetime accessor 323823894
424100894 https://github.com/pydata/xarray/pull/2144#issuecomment-424100894 https://api.github.com/repos/pydata/xarray/issues/2144 MDEyOklzc3VlQ29tbWVudDQyNDEwMDg5NA== abrammer 6145107 2018-09-24T19:45:54Z 2018-09-24T19:54:11Z CONTRIBUTOR

ok, thanks. Anything an outsider can help with?

 
{
    "total_count": 1,
    "+1": 1,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Add strftime() to datetime accessor 323823894
424100432 https://github.com/pydata/xarray/pull/2144#issuecomment-424100432 https://api.github.com/repos/pydata/xarray/issues/2144 MDEyOklzc3VlQ29tbWVudDQyNDEwMDQzMg== dopplershift 221526 2018-09-24T19:44:21Z 2018-09-24T19:44:21Z CONTRIBUTOR

Just haven't had the cycles to bring this to the finish line.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Add strftime() to datetime accessor 323823894
424096368 https://github.com/pydata/xarray/pull/2144#issuecomment-424096368 https://api.github.com/repos/pydata/xarray/issues/2144 MDEyOklzc3VlQ29tbWVudDQyNDA5NjM2OA== abrammer 6145107 2018-09-24T19:30:09Z 2018-09-24T19:30:09Z CONTRIBUTOR

Was looking for this functionality and came across the parent issue and this work around, did this just get forgotten or was there more work to be done? It'd be great to have this functionality readily available without having to work around. 

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Add strftime() to datetime accessor 323823894
389730062 https://github.com/pydata/xarray/pull/2144#issuecomment-389730062 https://api.github.com/repos/pydata/xarray/issues/2144 MDEyOklzc3VlQ29tbWVudDM4OTczMDA2Mg== dopplershift 221526 2018-05-17T03:04:56Z 2018-05-17T03:04:56Z CONTRIBUTOR

Since this can wait for 0.10.5, I can go slowly and get this right.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Add strftime() to datetime accessor 323823894
389718982 https://github.com/pydata/xarray/pull/2144#issuecomment-389718982 https://api.github.com/repos/pydata/xarray/issues/2144 MDEyOklzc3VlQ29tbWVudDM4OTcxODk4Mg== shoyer 1217238 2018-05-17T01:50:15Z 2018-05-17T01:50:15Z MEMBER

Sorry, it's too late for v0.10.4 (But my intent is not to wait too long for 0.10.5.)

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Add strftime() to datetime accessor 323823894
389712078 https://github.com/pydata/xarray/pull/2144#issuecomment-389712078 https://api.github.com/repos/pydata/xarray/issues/2144 MDEyOklzc3VlQ29tbWVudDM4OTcxMjA3OA== spencerkclark 6628425 2018-05-17T01:04:09Z 2018-05-17T01:04:09Z MEMBER

It might also be worth considering adding this accessor to CFTimeIndex, since cftime.datetime implements a version of strftime (that would enable use with dates from non-standard calendars). No worries if you'd rather put that off until later though.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Add strftime() to datetime accessor 323823894
389699324 https://github.com/pydata/xarray/pull/2144#issuecomment-389699324 https://api.github.com/repos/pydata/xarray/issues/2144 MDEyOklzc3VlQ29tbWVudDM4OTY5OTMyNA== dopplershift 221526 2018-05-16T23:40:32Z 2018-05-16T23:40:32Z CONTRIBUTOR

Any chance this makes it into 0.10.4?

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Add strftime() to datetime accessor 323823894

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);