issue_comments

Table actions

4 rows where issue = 323359733 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: created_at (date), updated_at (date)

issue 1

  • use CF conventions to enhance plot labels · 4 ✖

author_association 1

id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
389898818 https://github.com/pydata/xarray/issues/2135#issuecomment-389898818 https://api.github.com/repos/pydata/xarray/issues/2135 MDEyOklzc3VlQ29tbWVudDM4OTg5ODgxOA== dcherian 2448579 2018-05-17T15:03:12Z 2018-05-17T15:03:12Z MEMBER

I can do it. are we agreed that long_name, standard_name, and units are the attributes we want to follow? I think we should also add support for upper-case versions of these (I think I've seen those in the wild)

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   use CF conventions to enhance plot labels 323359733
389895669 https://github.com/pydata/xarray/issues/2135#issuecomment-389895669 https://api.github.com/repos/pydata/xarray/issues/2135 MDEyOklzc3VlQ29tbWVudDM4OTg5NTY2OQ== fmaussion 10050469 2018-05-17T14:54:49Z 2018-05-17T14:54:49Z MEMBER 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   use CF conventions to enhance plot labels 323359733
389890434 https://github.com/pydata/xarray/issues/2135#issuecomment-389890434 https://api.github.com/repos/pydata/xarray/issues/2135 MDEyOklzc3VlQ29tbWVudDM4OTg5MDQzNA== rabernat 1197350 2018-05-17T14:40:14Z 2018-05-17T14:40:14Z MEMBER

It would take me some time to wrap my head around the plotting code again, and as a result I don't anticipate having time to work on this any time soon.

I know @dcherian has been digging into the plotting functions a lot. I imagine that he would be able to implement this much faster than I would. Just leaving that suggestion out there... ;)

Obviously this is not an urgent issue.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   use CF conventions to enhance plot labels 323359733
389294518 https://github.com/pydata/xarray/issues/2135#issuecomment-389294518 https://api.github.com/repos/pydata/xarray/issues/2135 MDEyOklzc3VlQ29tbWVudDM4OTI5NDUxOA== shoyer 1217238 2018-05-15T20:00:31Z 2018-05-15T20:00:31Z MEMBER

Default labels are intended more for convenience than anything else. For publication/production purposes, I suspect labels are almost always been explicitly set, anyways.

So I think this convention makes sense. Let's just document it directly in the plotting docs, maybe even by including your label_from_attrs() function to make it fully explicit. That way non-weather/climate users can also make use of it, without referring to the full CF conventions spec.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   use CF conventions to enhance plot labels 323359733

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);