issue_comments

Table actions

2 rows where issue = 322445312 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: created_at (date), updated_at (date)

user 2

author_association 2

issue 1

  • rasterio backend should use DataStorePickleMixin (or something similar) · 2 ✖
id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
388922657 https://github.com/pydata/xarray/issues/2121#issuecomment-388922657 https://api.github.com/repos/pydata/xarray/issues/2121 MDEyOklzc3VlQ29tbWVudDM4ODkyMjY1Nw== shoyer 1217238 2018-05-14T18:47:55Z 2018-05-14T18:47:55Z MEMBER

The simplest design here would be to extract the logic from DataStorePickleMixin into a pickleable wrapper class that could be used in rasterio.open().

e.g., instead of riods = rasterio.open(filename, mode='r') we would write riods_wrapper = PickleByReconstructionWrapper(rasterio.open, filename, mode='r')

PickleByReconstructionWrapper would need to define __setstate__/__getstate__ (for pickleability), and would also have a .value attribute for pulling out the unwrapped file object.

Eventually, we should probably refactor xarray's existing data stores to use this -- the current logic is really messy/hard to understand. We'll probably also want to eventually factor out the auto-close logic in some composable way, but that can be saved for later.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   rasterio backend should use DataStorePickleMixin (or something similar) 322445312
388786292 https://github.com/pydata/xarray/issues/2121#issuecomment-388786292 https://api.github.com/repos/pydata/xarray/issues/2121 MDEyOklzc3VlQ29tbWVudDM4ODc4NjI5Mg== rsignell-usgs 1872600 2018-05-14T11:34:45Z 2018-05-14T11:34:45Z NONE

@jhamman what kind of expertise would it take to do this job (e.g, it just a copy-and-paste with some small changes that a newbie could probably do, or would it be best for core dev team)?

And is there any workaround that can be used in the interim?

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   rasterio backend should use DataStorePickleMixin (or something similar) 322445312

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);