issue_comments

Table actions

5 rows where issue = 317954266 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: created_at (date), updated_at (date)

user 3

author_association 2

issue 1

  • units = 'days' leads to timedelta64 for data variable · 5 ✖
id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
384710080 https://github.com/pydata/xarray/issues/2085#issuecomment-384710080 https://api.github.com/repos/pydata/xarray/issues/2085 MDEyOklzc3VlQ29tbWVudDM4NDcxMDA4MA== ocefpaf 950575 2018-04-26T16:44:25Z 2018-04-26T16:44:25Z CONTRIBUTOR

Thanks! I'll look into those and should have something by next week.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   units = 'days' leads to timedelta64 for data variable 317954266
384709521 https://github.com/pydata/xarray/issues/2085#issuecomment-384709521 https://api.github.com/repos/pydata/xarray/issues/2085 MDEyOklzc3VlQ29tbWVudDM4NDcwOTUyMQ== shoyer 1217238 2018-04-26T16:42:31Z 2018-04-26T16:42:31Z MEMBER

@ocefpaf I suggested one option in https://github.com/pydata/xarray/issues/1621#issuecomment-339116478, issuing a FutureWarning so anyone reliant on this behavior is not surprised. (We could also add an option for opting into the behavior early if you like, e.g., xarray.set_options(enable_future_time_unit_decoding=True) like in #1252.)

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   units = 'days' leads to timedelta64 for data variable 317954266
384704926 https://github.com/pydata/xarray/issues/2085#issuecomment-384704926 https://api.github.com/repos/pydata/xarray/issues/2085 MDEyOklzc3VlQ29tbWVudDM4NDcwNDkyNg== ocefpaf 950575 2018-04-26T16:28:04Z 2018-04-26T16:28:04Z CONTRIBUTOR

@shoyer what is the path forward? In https://github.com/pydata/xarray/pull/940 I implemented a keyword so we could keep both behaviors, which I believe is a bad idea.

Would a PR changing the current behavior and return floats instead timedelta64 be OK? If so I can try to put that together over this weekend. 

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   units = 'days' leads to timedelta64 for data variable 317954266
384703545 https://github.com/pydata/xarray/issues/2085#issuecomment-384703545 https://api.github.com/repos/pydata/xarray/issues/2085 MDEyOklzc3VlQ29tbWVudDM4NDcwMzU0NQ== mathause 10194086 2018-04-26T16:23:47Z 2018-04-26T16:23:47Z MEMBER

Thanks & sorry I didn't see the other issue.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   units = 'days' leads to timedelta64 for data variable 317954266
384693762 https://github.com/pydata/xarray/issues/2085#issuecomment-384693762 https://api.github.com/repos/pydata/xarray/issues/2085 MDEyOklzc3VlQ29tbWVudDM4NDY5Mzc2Mg== shoyer 1217238 2018-04-26T15:55:09Z 2018-04-26T15:55:09Z MEMBER

This is expected behavior, but you're not the first person to complain, and it seems like there is a consensus around changing it: https://github.com/pydata/xarray/issues/1621

I'm going to close this issue in favor of the other one.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   units = 'days' leads to timedelta64 for data variable 317954266

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);