issue_comments

Table actions

3 rows where issue = 31510183 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: created_at (date), updated_at (date)

user 2

author_association 2

issue 1

  • Dataset.concat() can now automatically concat over non-equal variables. · 3 ✖
id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
40772008 https://github.com/pydata/xarray/pull/102#issuecomment-40772008 https://api.github.com/repos/pydata/xarray/issues/102 MDEyOklzc3VlQ29tbWVudDQwNzcyMDA4 shoyer 1217238 2014-04-17T22:58:06Z 2014-04-17T22:58:06Z MEMBER

OK, I think we can safely merge this. Would it make sense to add the same options to DataArray.concat?

I'd like to eventually write a global function xray.concat which concatenate Datasets or DataArrays, based on the type of the first element.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Dataset.concat() can now automatically concat over non-equal variables. 31510183
40426850 https://github.com/pydata/xarray/pull/102#issuecomment-40426850 https://api.github.com/repos/pydata/xarray/issues/102 MDEyOklzc3VlQ29tbWVudDQwNDI2ODUw shoyer 1217238 2014-04-14T22:39:41Z 2014-04-14T22:39:41Z MEMBER

Yes, I am certainly open to revisiting this. I'm not particularly enamored of the current arguments -- especially concat_over, which I think is a little confusing.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Dataset.concat() can now automatically concat over non-equal variables. 31510183
40425993 https://github.com/pydata/xarray/pull/102#issuecomment-40425993 https://api.github.com/repos/pydata/xarray/issues/102 MDEyOklzc3VlQ29tbWVudDQwNDI1OTkz akleeman 514053 2014-04-14T22:28:31Z 2014-04-14T22:28:31Z CONTRIBUTOR

Sounds good, I'd also like to consider renaming the behavior/arguments in concat. Or maybe add an additional argument with options along the lines of 'shared-dimension', 'different', 'all'. Which would allow the user to choose which variables are concatenated (ie, variables with dimension == 'concat_dimension' those that are different across datasets (even if they don't follow 'concat_dimension') and all variables.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Dataset.concat() can now automatically concat over non-equal variables. 31510183

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);