issue_comments

Table actions

9 rows where issue = 309378665 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: reactions, created_at (date), updated_at (date)

author_association 3

issue 1

  • quantile method returns quantile coordinates which can raise issues · 9 ✖
id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
592041773 https://github.com/pydata/xarray/issues/2023#issuecomment-592041773 https://api.github.com/repos/pydata/xarray/issues/2023 MDEyOklzc3VlQ29tbWVudDU5MjA0MTc3Mw== stale[bot] 26384082 2020-02-27T16:11:35Z 2020-02-27T16:11:35Z NONE

In order to maintain a list of currently relevant issues, we mark issues as stale after a period of inactivity

If this issue remains relevant, please comment here or remove the stale label; otherwise it will be marked as closed automatically

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   quantile method returns quantile coordinates which can raise issues 309378665
377249450 https://github.com/pydata/xarray/issues/2023#issuecomment-377249450 https://api.github.com/repos/pydata/xarray/issues/2023 MDEyOklzc3VlQ29tbWVudDM3NzI0OTQ1MA== chiaral 8453445 2018-03-29T14:16:39Z 2018-03-29T14:16:39Z CONTRIBUTOR

(short introduction: I created this issue, but I didn't realize I was logged in into another account) I am not sure I have a constructive comment on how to name it.
If the future version will deprecate the attribute style access, I can see how it won't be a problem eventually, but I though to open this issue to bring it up.

how about just "q", since that is the name of the parameter? too short? 

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   quantile method returns quantile coordinates which can raise issues 309378665
377090448 https://github.com/pydata/xarray/issues/2023#issuecomment-377090448 https://api.github.com/repos/pydata/xarray/issues/2023 MDEyOklzc3VlQ29tbWVudDM3NzA5MDQ0OA== shoyer 1217238 2018-03-29T01:22:52Z 2018-03-29T01:22:52Z MEMBER

I suppose another choice would be to make this entirely explicit in the future, e.g,. require passing in quantiles as a 1D xarray.DataArray or pandas.Index. I don't know if that would really make people happier.

 
{
    "total_count": 1,
    "+1": 0,
    "-1": 1,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   quantile method returns quantile coordinates which can raise issues 309378665
377059396 https://github.com/pydata/xarray/issues/2023#issuecomment-377059396 https://api.github.com/repos/pydata/xarray/issues/2023 MDEyOklzc3VlQ29tbWVudDM3NzA1OTM5Ng== max-sixty 5635139 2018-03-28T22:30:48Z 2018-03-28T22:30:48Z MEMBER

percentile / quantile_dim?

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   quantile method returns quantile coordinates which can raise issues 309378665
377045779 https://github.com/pydata/xarray/issues/2023#issuecomment-377045779 https://api.github.com/repos/pydata/xarray/issues/2023 MDEyOklzc3VlQ29tbWVudDM3NzA0NTc3OQ== fmaussion 10050469 2018-03-28T21:37:31Z 2018-03-28T21:37:31Z MEMBER

quantiles with an s?

percentile ?

 
{
    "total_count": 1,
    "+1": 1,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   quantile method returns quantile coordinates which can raise issues 309378665
377039470 https://github.com/pydata/xarray/issues/2023#issuecomment-377039470 https://api.github.com/repos/pydata/xarray/issues/2023 MDEyOklzc3VlQ29tbWVudDM3NzAzOTQ3MA== shoyer 1217238 2018-03-28T21:15:51Z 2018-03-28T21:15:51Z MEMBER

Any ideas for an alternative dimension name?

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   quantile method returns quantile coordinates which can raise issues 309378665
376980278 https://github.com/pydata/xarray/issues/2023#issuecomment-376980278 https://api.github.com/repos/pydata/xarray/issues/2023 MDEyOklzc3VlQ29tbWVudDM3Njk4MDI3OA== fmaussion 10050469 2018-03-28T18:02:51Z 2018-03-28T18:02:51Z MEMBER

we were discussion discouraging, if not deprecating, the attribute style access of variables

I guess this came up with .transpose() and .T: https://github.com/pydata/xarray/pull/1643 , https://github.com/pydata/xarray/issues/1232

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   quantile method returns quantile coordinates which can raise issues 309378665
376954998 https://github.com/pydata/xarray/issues/2023#issuecomment-376954998 https://api.github.com/repos/pydata/xarray/issues/2023 MDEyOklzc3VlQ29tbWVudDM3Njk1NDk5OA== jhamman 2443309 2018-03-28T16:45:04Z 2018-03-28T16:45:04Z MEMBER

At one point we were discussion discouraging, if not deprecating, the attribute style access of variables. I can't seem to find that issue now though...

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   quantile method returns quantile coordinates which can raise issues 309378665
376947952 https://github.com/pydata/xarray/issues/2023#issuecomment-376947952 https://api.github.com/repos/pydata/xarray/issues/2023 MDEyOklzc3VlQ29tbWVudDM3Njk0Nzk1Mg== max-sixty 5635139 2018-03-28T16:22:43Z 2018-03-28T16:22:43Z MEMBER

I think that's right. While strictly the dict lookup is more robust, we should at least attempt not to cause a conflict there

 
{
    "total_count": 1,
    "+1": 1,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   quantile method returns quantile coordinates which can raise issues 309378665

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);