issue_comments

Table actions

7 rows where issue = 309098246 sorted by updated_at descending

✖
✖

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: created_at (date), updated_at (date)

author_association 3

issue 1

  • np.minimum.accumulate(da) doesn't work · 7 ✖
id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
592170078 https://github.com/pydata/xarray/issues/2017#issuecomment-592170078 https://api.github.com/repos/pydata/xarray/issues/2017 MDEyOklzc3VlQ29tbWVudDU5MjE3MDA3OA== max-sixty 5635139 2020-02-27T20:49:38Z 2020-02-27T20:49:38Z MEMBER

No prob, appreciate the issue regardless

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   np.minimum.accumulate(da) doesn't work 309098246
592151913 https://github.com/pydata/xarray/issues/2017#issuecomment-592151913 https://api.github.com/repos/pydata/xarray/issues/2017 MDEyOklzc3VlQ29tbWVudDU5MjE1MTkxMw== seth-p 7441788 2020-02-27T20:04:44Z 2020-02-27T20:04:44Z CONTRIBUTOR

I'm afraid I'm not able to submit a PR. Sorry.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   np.minimum.accumulate(da) doesn't work 309098246
592094915 https://github.com/pydata/xarray/issues/2017#issuecomment-592094915 https://api.github.com/repos/pydata/xarray/issues/2017 MDEyOklzc3VlQ29tbWVudDU5MjA5NDkxNQ== max-sixty 5635139 2020-02-27T17:59:36Z 2020-02-27T17:59:36Z MEMBER

@seth-p thanks for tracking that down. To the extent you'd be up for a PR, we'd gratefully merge one!

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   np.minimum.accumulate(da) doesn't work 309098246
592033172 https://github.com/pydata/xarray/issues/2017#issuecomment-592033172 https://api.github.com/repos/pydata/xarray/issues/2017 MDEyOklzc3VlQ29tbWVudDU5MjAzMzE3Mg== seth-p 7441788 2020-02-27T15:55:23Z 2020-02-27T15:55:23Z CONTRIBUTOR

I think the only necessary changes are (a) delete the if method != "__call__" check (https://github.com/pydata/xarray/blob/master/xarray/core/arithmetic.py#L49), and (b) in the apply_ufunc() call, replace ufunc with getattr(ufunc, method) (https://github.com/pydata/xarray/blob/master/xarray/core/arithmetic.py#L71).

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   np.minimum.accumulate(da) doesn't work 309098246
592027630 https://github.com/pydata/xarray/issues/2017#issuecomment-592027630 https://api.github.com/repos/pydata/xarray/issues/2017 MDEyOklzc3VlQ29tbWVudDU5MjAyNzYzMA== seth-p 7441788 2020-02-27T15:38:05Z 2020-02-27T15:38:05Z CONTRIBUTOR

This issue is still relevant.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   np.minimum.accumulate(da) doesn't work 309098246
591838727 https://github.com/pydata/xarray/issues/2017#issuecomment-591838727 https://api.github.com/repos/pydata/xarray/issues/2017 MDEyOklzc3VlQ29tbWVudDU5MTgzODcyNw== stale[bot] 26384082 2020-02-27T08:11:34Z 2020-02-27T08:11:34Z NONE

In order to maintain a list of currently relevant issues, we mark issues as stale after a period of inactivity

If this issue remains relevant, please comment here or remove the stale label; otherwise it will be marked as closed automatically

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   np.minimum.accumulate(da) doesn't work 309098246
376652233 https://github.com/pydata/xarray/issues/2017#issuecomment-376652233 https://api.github.com/repos/pydata/xarray/issues/2017 MDEyOklzc3VlQ29tbWVudDM3NjY1MjIzMw== shoyer 1217238 2018-03-27T19:49:54Z 2018-03-27T19:49:54Z MEMBER

I think this would be pretty straightforward to add to our __array_ufunc__ implementation, possibly as simple as not raising if method='accumulate': https://github.com/pydata/xarray/blob/master/xarray/core/arithmetic.py

It would need tests, though.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   np.minimum.accumulate(da) doesn't work 309098246

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);