issue_comments

Table actions

7 rows where issue = 302695966 sorted by updated_at descending

✖
✖

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: reactions, created_at (date), updated_at (date)

user 3

author_association 2

issue 1

  • Fix RGB imshow with X or Y dim of size one · 7 ✖
id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
371665467 https://github.com/pydata/xarray/pull/1967#issuecomment-371665467 https://api.github.com/repos/pydata/xarray/issues/1967 MDEyOklzc3VlQ29tbWVudDM3MTY2NTQ2Nw== shoyer 1217238 2018-03-08T23:51:42Z 2018-03-08T23:51:42Z MEMBER

OK, I'm going to merge this. Thanks @Zac-HD 

{
    "total_count": 1,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 1,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Fix RGB imshow with X or Y dim of size one 302695966
371011595 https://github.com/pydata/xarray/pull/1967#issuecomment-371011595 https://api.github.com/repos/pydata/xarray/issues/1967 MDEyOklzc3VlQ29tbWVudDM3MTAxMTU5NQ== Zac-HD 12229877 2018-03-07T03:34:37Z 2018-03-07T03:34:37Z CONTRIBUTOR

Not any more :wink: - it links to the docs that "[xarray.plot.plot()] calls an xarray plotting function based on the dimensions of darray.squeeze()".

I'd actually like to keep the magic in plot() - the whole point of this is that we can do something with the data, not that we do anything in particular. For interactive use, this is valuable enough - in my view - to justify keeping an inconsistent API; particularly when there is an obvious non-magic version to use in a script. In any case, that's a topic for another pull.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Fix RGB imshow with X or Y dim of size one 302695966
370974503 https://github.com/pydata/xarray/pull/1967#issuecomment-370974503 https://api.github.com/repos/pydata/xarray/issues/1967 MDEyOklzc3VlQ29tbWVudDM3MDk3NDUwMw== Zac-HD 12229877 2018-03-07T00:06:15Z 2018-03-07T03:08:31Z CONTRIBUTOR

Ah, I see what you mean but don't think we need any change or additional test.

There's a catch though - xarray.plot() is special, because it (and only it) squeezes the dimensions of the array before plotting it. Therefore, the following calls all produce the same plot:

xr.DataArray(np.arange(9).reshape((3,3))).plot()
xr.DataArray(np.arange(9).reshape((1,3,3))).plot()
xr.DataArray(np.arange(9).reshape((1,1,3,1,1,1,1,3,1,1))).plot()

My view is that the test you linked to is sufficient for the test you're asking for - imshow is a special case because it can accept 3D input for RGB plots.

TLDR - working as intended IMO, it's just that nobody reads the docs. Changing the API would avoid this but at cost of convenience which is the whole point of DataArray.plot().

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Fix RGB imshow with X or Y dim of size one 302695966
371004622 https://github.com/pydata/xarray/pull/1967#issuecomment-371004622 https://api.github.com/repos/pydata/xarray/issues/1967 MDEyOklzc3VlQ29tbWVudDM3MTAwNDYyMg== shoyer 1217238 2018-03-07T02:50:01Z 2018-03-07T02:50:01Z MEMBER

@Zac-HD your link on squeezing goes back to this page :).

Possibly we should deprecate and/or remove the auto-squeezing behavior? That sort of magic can be pretty frustrating to debug.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Fix RGB imshow with X or Y dim of size one 302695966
370815473 https://github.com/pydata/xarray/pull/1967#issuecomment-370815473 https://api.github.com/repos/pydata/xarray/issues/1967 MDEyOklzc3VlQ29tbWVudDM3MDgxNTQ3Mw== fmaussion 10050469 2018-03-06T15:19:09Z 2018-03-06T15:19:09Z MEMBER

As a regression test it's specific to imshow, so I'm not sure what you'd want here (or whether it would work at all on the 2d mixin). More details please?

Yes sorry: I think it should work same for all four 2d plot methods (we should have had a test for this)

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Fix RGB imshow with X or Y dim of size one 302695966
370813600 https://github.com/pydata/xarray/pull/1967#issuecomment-370813600 https://api.github.com/repos/pydata/xarray/issues/1967 MDEyOklzc3VlQ29tbWVudDM3MDgxMzYwMA== Zac-HD 12229877 2018-03-06T15:13:43Z 2018-03-06T15:13:43Z CONTRIBUTOR

No problem - I had an hour free and no open pulls waiting on me, so the timing was good.

As a regression test it's specific to imshow, so I'm not sure what you'd want here (or whether it would work at all on the 2d mixin). More details please? 

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Fix RGB imshow with X or Y dim of size one 302695966
370807682 https://github.com/pydata/xarray/pull/1967#issuecomment-370807682 https://api.github.com/repos/pydata/xarray/issues/1967 MDEyOklzc3VlQ29tbWVudDM3MDgwNzY4Mg== fmaussion 10050469 2018-03-06T14:56:00Z 2018-03-06T14:56:00Z MEMBER

Wow that was fast, thanks!

Would it be possible to add the test to the Common2dMixin class instead? (exmaple here)

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Fix RGB imshow with X or Y dim of size one 302695966

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);