issue_comments

Table actions

6 rows where issue = 302447879 sorted by updated_at descending

✖
✖

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: created_at (date), updated_at (date)

user 3

author_association 2

issue 1

  • avoid integer overflow when decoding large time numbers · 6 ✖
id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
385612859 https://github.com/pydata/xarray/pull/1965#issuecomment-385612859 https://api.github.com/repos/pydata/xarray/issues/1965 MDEyOklzc3VlQ29tbWVudDM4NTYxMjg1OQ== j08lue 3404817 2018-05-01T07:03:53Z 2018-05-01T07:03:53Z CONTRIBUTOR

mind freshening up this PR

I deleted my fork in the meantime. I opened a new PR at #2096 and fixed the merge conflict there.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   avoid integer overflow when decoding large time numbers 302447879
385598489 https://github.com/pydata/xarray/pull/1965#issuecomment-385598489 https://api.github.com/repos/pydata/xarray/issues/1965 MDEyOklzc3VlQ29tbWVudDM4NTU5ODQ4OQ== jhamman 2443309 2018-05-01T04:46:51Z 2018-05-01T04:46:51Z MEMBER

@j08lue - mind freshening up this PR? It seems there are some conflicts that need to be resolved before merging. 

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   avoid integer overflow when decoding large time numbers 302447879
371758069 https://github.com/pydata/xarray/pull/1965#issuecomment-371758069 https://api.github.com/repos/pydata/xarray/issues/1965 MDEyOklzc3VlQ29tbWVudDM3MTc1ODA2OQ== j08lue 3404817 2018-03-09T09:19:38Z 2018-03-09T09:19:38Z CONTRIBUTOR

Can you add a brief note on the bug fix in whats-new?

Done.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   avoid integer overflow when decoding large time numbers 302447879
371717137 https://github.com/pydata/xarray/pull/1965#issuecomment-371717137 https://api.github.com/repos/pydata/xarray/issues/1965 MDEyOklzc3VlQ29tbWVudDM3MTcxNzEzNw== shoyer 1217238 2018-03-09T05:25:14Z 2018-03-09T05:25:14Z MEMBER

OK, this seems reasonable to me. Can you add a brief note on the bug fix in whats-new?

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   avoid integer overflow when decoding large time numbers 302447879
370571480 https://github.com/pydata/xarray/pull/1965#issuecomment-370571480 https://api.github.com/repos/pydata/xarray/issues/1965 MDEyOklzc3VlQ29tbWVudDM3MDU3MTQ4MA== j08lue 3404817 2018-03-05T21:25:53Z 2018-03-06T07:18:40Z CONTRIBUTOR 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   avoid integer overflow when decoding large time numbers 302447879
370568574 https://github.com/pydata/xarray/pull/1965#issuecomment-370568574 https://api.github.com/repos/pydata/xarray/issues/1965 MDEyOklzc3VlQ29tbWVudDM3MDU2ODU3NA== j08lue 3404817 2018-03-05T21:16:28Z 2018-03-05T21:29:19Z CONTRIBUTOR

Seems like this issue only exists on Windows. See https://ci.appveyor.com/project/shoyer/xray/build/1.0.3782/job/yjodrbenev1tw5y7#L4686

(The Travis failure is due to a failing build.)

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   avoid integer overflow when decoding large time numbers 302447879

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);