issue_comments

Table actions

11 rows where issue = 299346082 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: created_at (date), updated_at (date)

author_association 3

issue 1

  • Not compatible with PyPy and dask.array. · 11 ✖
id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
368687352 https://github.com/pydata/xarray/issues/1935#issuecomment-368687352 https://api.github.com/repos/pydata/xarray/issues/1935 MDEyOklzc3VlQ29tbWVudDM2ODY4NzM1Mg== jhamman 2443309 2018-02-26T23:22:37Z 2018-02-26T23:22:37Z MEMBER

I'm going to close now seeing that the upstream/pypy issue has been closed.

@tlechauve - please keep us updated on the pypy integration of xarray and the development of your REST API. 

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Not compatible with PyPy and dask.array. 299346082
368173087 https://github.com/pydata/xarray/issues/1935#issuecomment-368173087 https://api.github.com/repos/pydata/xarray/issues/1935 MDEyOklzc3VlQ29tbWVudDM2ODE3MzA4Nw== lesserwhirls 67096 2018-02-23T23:54:26Z 2018-02-23T23:54:26Z NONE

Sounds interesting!

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Not compatible with PyPy and dask.array. 299346082
368171446 https://github.com/pydata/xarray/issues/1935#issuecomment-368171446 https://api.github.com/repos/pydata/xarray/issues/1935 MDEyOklzc3VlQ29tbWVudDM2ODE3MTQ0Ng== dopplershift 221526 2018-02-23T23:43:07Z 2018-02-23T23:43:07Z CONTRIBUTOR

@tlechauve One way or another, I'm sure @lesserwhirls would be interested to hear your thoughts on THREDDS.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Not compatible with PyPy and dask.array. 299346082
368129811 https://github.com/pydata/xarray/issues/1935#issuecomment-368129811 https://api.github.com/repos/pydata/xarray/issues/1935 MDEyOklzc3VlQ29tbWVudDM2ODEyOTgxMQ== tlechauve 1102577 2018-02-23T20:29:06Z 2018-02-23T20:29:06Z NONE

@jhamman I'm working on a light/python version of Thredds. it's not planned for now to be Open-source but i will think about it when a stable version will be available.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Not compatible with PyPy and dask.array. 299346082
368082271 https://github.com/pydata/xarray/issues/1935#issuecomment-368082271 https://api.github.com/repos/pydata/xarray/issues/1935 MDEyOklzc3VlQ29tbWVudDM2ODA4MjI3MQ== jhamman 2443309 2018-02-23T17:37:42Z 2018-02-23T17:37:42Z MEMBER

@tlechauve - If your REST API is open source, would you mind sharing a link? I'd be interested to see what you're up to. 

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Not compatible with PyPy and dask.array. 299346082
367946371 https://github.com/pydata/xarray/issues/1935#issuecomment-367946371 https://api.github.com/repos/pydata/xarray/issues/1935 MDEyOklzc3VlQ29tbWVudDM2Nzk0NjM3MQ== tlechauve 1102577 2018-02-23T08:45:48Z 2018-02-23T08:45:48Z NONE

HI @benbovy,

Actually its not really an issue and its not related to xarray, i'm using falcon to make a REST API which provide netCDF data with xarray/dask.

According to falcon benchmarks, pypy has better performance. But maybe in this case i should use CPython.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Not compatible with PyPy and dask.array. 299346082
367843351 https://github.com/pydata/xarray/issues/1935#issuecomment-367843351 https://api.github.com/repos/pydata/xarray/issues/1935 MDEyOklzc3VlQ29tbWVudDM2Nzg0MzM1MQ== benbovy 4160723 2018-02-22T22:24:34Z 2018-02-22T22:24:34Z MEMBER

With the standard python everything works, but i have performance issues.

Can I ask what kind of performance issues do you have? I don't have much experience with PyPy, I'm just curious on cases where using xarray with PyPy represents a real advantage over using it with CPython.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Not compatible with PyPy and dask.array. 299346082
367815913 https://github.com/pydata/xarray/issues/1935#issuecomment-367815913 https://api.github.com/repos/pydata/xarray/issues/1935 MDEyOklzc3VlQ29tbWVudDM2NzgxNTkxMw== tlechauve 1102577 2018-02-22T20:44:17Z 2018-02-22T20:44:17Z NONE 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Not compatible with PyPy and dask.array. 299346082
367809113 https://github.com/pydata/xarray/issues/1935#issuecomment-367809113 https://api.github.com/repos/pydata/xarray/issues/1935 MDEyOklzc3VlQ29tbWVudDM2NzgwOTExMw== tlechauve 1102577 2018-02-22T20:19:44Z 2018-02-22T20:19:44Z NONE

@shoyer you are right !

``` Python 2.7.8 (2.4.0+dfsg-3, Dec 20 2014, 13:30:46) [PyPy 2.4.0 with GCC 4.9.2] on linux2 Type "help", "copyright", "credits" or "license" for more information.

import weakref import threading lock = threading.Lock() locks = weakref.WeakValueDictionary() locks['foo'] = lock Traceback (most recent call last): File "<stdin>", line 1, in <module> File "/usr/lib/pypy/lib-python/2.7/weakref.py", line 108, in setitem self.data[key] = KeyedRef(value, self._remove, key) File "/usr/lib/pypy/lib-python/2.7/weakref.py", line 274, in new self = ref.new(type, ob, callback) TypeError: cannot create weak reference to 'thread.lock' object ```

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Not compatible with PyPy and dask.array. 299346082
367802779 https://github.com/pydata/xarray/issues/1935#issuecomment-367802779 https://api.github.com/repos/pydata/xarray/issues/1935 MDEyOklzc3VlQ29tbWVudDM2NzgwMjc3OQ== mrocklin 306380 2018-02-22T19:58:55Z 2018-02-22T19:58:55Z MEMBER

+1 on reporting upstream if convenient

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Not compatible with PyPy and dask.array. 299346082
367795719 https://github.com/pydata/xarray/issues/1935#issuecomment-367795719 https://api.github.com/repos/pydata/xarray/issues/1935 MDEyOklzc3VlQ29tbWVudDM2Nzc5NTcxOQ== shoyer 1217238 2018-02-22T19:37:51Z 2018-02-22T19:37:51Z MEMBER

It's exciting to see people testing xarray with PyPy! Once we get this working, we should consider adding a continuous integration test.

The specific problem here seems to be dask.SerializableLock, which xarray initializes upon import: https://github.com/dask/dask/blob/de6c2a49d76066abb51085570816322f063fc5c5/dask/utils.py#L737

I think this could be reproduced with something like the following using only the standard library: ``` import weakref import threading

lock = threading.Lock()

locks = weakref.WeakValueDictionary() locks['foo'] = lock ```

This works with CPython, but maybe not with pypy.

CC @mrocklin in case he has any ideas. Otherwise if my code to reproduce works, I would suggest reporting this upstream to PyPy.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Not compatible with PyPy and dask.array. 299346082

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);