issue_comments

Table actions

4 rows where issue = 297452821 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: reactions, created_at (date), updated_at (date)

user 3

author_association 2

issue 1

  • Code review bots? · 4 ✖
id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
369106762 https://github.com/pydata/xarray/issues/1912#issuecomment-369106762 https://api.github.com/repos/pydata/xarray/issues/1912 MDEyOklzc3VlQ29tbWVudDM2OTEwNjc2Mg== Zac-HD 12229877 2018-02-28T03:09:46Z 2018-02-28T03:09:46Z CONTRIBUTOR

Per comment on the pull: my experience is that bots are a great complement, but can't replace style checks in CI.

Only remove flake8 from Travis if you're OK with merging pulls that don't meet the style guide (and then amend the contributing guide to match) - that's a valid decision, but also a weaker position than Xarray has previously taken.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Code review bots? 297452821
366171791 https://github.com/pydata/xarray/issues/1912#issuecomment-366171791 https://api.github.com/repos/pydata/xarray/issues/1912 MDEyOklzc3VlQ29tbWVudDM2NjE3MTc5MQ== fujiisoup 6815844 2018-02-16T08:25:34Z 2018-02-16T08:25:34Z MEMBER

I think we can remove the flake8 test in travis. It would make clear on github whether tests fail or code style issues.

 
{
    "total_count": 1,
    "+1": 0,
    "-1": 1,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Code review bots? 297452821
365986680 https://github.com/pydata/xarray/issues/1912#issuecomment-365986680 https://api.github.com/repos/pydata/xarray/issues/1912 MDEyOklzc3VlQ29tbWVudDM2NTk4NjY4MA== shoyer 1217238 2018-02-15T16:42:45Z 2018-02-15T16:42:45Z MEMBER

Let me know if you don't have the permissions to add it and I should be able to help.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Code review bots? 297452821
365983314 https://github.com/pydata/xarray/issues/1912#issuecomment-365983314 https://api.github.com/repos/pydata/xarray/issues/1912 MDEyOklzc3VlQ29tbWVudDM2NTk4MzMxNA== shoyer 1217238 2018-02-15T16:32:53Z 2018-02-15T16:32:53Z MEMBER

Sure, automated comments on a pull request are definitely friendlier than a failed Travis-CI build.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Code review bots? 297452821

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);