issue_comments

Table actions

8 rows where issue = 296867544 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: created_at (date), updated_at (date)

user 3

issue 1

  • Build documentation on TravisCI · 8 ✖

author_association 1

id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
366021245 https://github.com/pydata/xarray/pull/1908#issuecomment-366021245 https://api.github.com/repos/pydata/xarray/issues/1908 MDEyOklzc3VlQ29tbWVudDM2NjAyMTI0NQ== jhamman 2443309 2018-02-15T18:38:58Z 2018-02-15T18:38:58Z MEMBER

I had the fail-on-warning option turned on. I agree we should drop that for now. After we merge this, I'll open an issue to track cleaning those up at some point. I don't have time to fix them right now. 

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Build documentation on TravisCI 296867544
365858122 https://github.com/pydata/xarray/pull/1908#issuecomment-365858122 https://api.github.com/repos/pydata/xarray/issues/1908 MDEyOklzc3VlQ29tbWVudDM2NTg1ODEyMg== fmaussion 10050469 2018-02-15T08:35:27Z 2018-02-15T08:35:27Z MEMBER

Currently we have 106 warnings at doc build on my system

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Build documentation on TravisCI 296867544
365857533 https://github.com/pydata/xarray/pull/1908#issuecomment-365857533 https://api.github.com/repos/pydata/xarray/issues/1908 MDEyOklzc3VlQ29tbWVudDM2NTg1NzUzMw== fmaussion 10050469 2018-02-15T08:32:48Z 2018-02-15T08:32:48Z MEMBER

We should either fix these warnings or stop them from failing the build :)

It's really hard to get rid of all of them - I'd rather try option B ;)

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Build documentation on TravisCI 296867544
365840133 https://github.com/pydata/xarray/pull/1908#issuecomment-365840133 https://api.github.com/repos/pydata/xarray/issues/1908 MDEyOklzc3VlQ29tbWVudDM2NTg0MDEzMw== shoyer 1217238 2018-02-15T06:51:21Z 2018-02-15T06:51:21Z MEMBER

It looks like the doc build fails when it hits a warning: Warning, treated as error: /home/travis/build/pydata/xarray/doc/api.rst:1: WARNING: Inline emphasis start-string without end-string.

We should either fix these warnings or stop them from failing the build :)

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Build documentation on TravisCI 296867544
365407044 https://github.com/pydata/xarray/pull/1908#issuecomment-365407044 https://api.github.com/repos/pydata/xarray/issues/1908 MDEyOklzc3VlQ29tbWVudDM2NTQwNzA0NA== jhamman 2443309 2018-02-13T21:17:06Z 2018-02-13T21:17:06Z MEMBER

Well isn't that nice. CI is a two edged sword! I'll take a look.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Build documentation on TravisCI 296867544
365405172 https://github.com/pydata/xarray/pull/1908#issuecomment-365405172 https://api.github.com/repos/pydata/xarray/issues/1908 MDEyOklzc3VlQ29tbWVudDM2NTQwNTE3Mg== shoyer 1217238 2018-02-13T21:10:17Z 2018-02-13T21:10:17Z MEMBER

The build is failing with an error message about upgrading ruby?!?

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Build documentation on TravisCI 296867544
365404440 https://github.com/pydata/xarray/pull/1908#issuecomment-365404440 https://api.github.com/repos/pydata/xarray/issues/1908 MDEyOklzc3VlQ29tbWVudDM2NTQwNDQ0MA== shoyer 1217238 2018-02-13T21:07:29Z 2018-02-13T21:07:29Z MEMBER

This is really good idea, thanks!

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Build documentation on TravisCI 296867544
365387791 https://github.com/pydata/xarray/pull/1908#issuecomment-365387791 https://api.github.com/repos/pydata/xarray/issues/1908 MDEyOklzc3VlQ29tbWVudDM2NTM4Nzc5MQ== jhamman 2443309 2018-02-13T20:06:42Z 2018-02-13T20:06:42Z MEMBER

I think we've talked about doing this a number of times in the past. It seems that we've been running into a number of uncaught build failures (e.g. #1898, #1881). This is one way of testing that the documentation build will pass on read the docs. If someone has a better of idea of how to do this, I'm all ears.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Build documentation on TravisCI 296867544

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);