issue_comments

Table actions

2 rows where issue = 294735496 and user = 1217238 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: created_at (date), updated_at (date)

user 1

  • shoyer · 2 ✖

issue 1

  • call to colorbar not thread safe · 2 ✖

author_association 1

id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
364518238 https://github.com/pydata/xarray/issues/1889#issuecomment-364518238 https://api.github.com/repos/pydata/xarray/issues/1889 MDEyOklzc3VlQ29tbWVudDM2NDUxODIzOA== shoyer 1217238 2018-02-09T18:31:28Z 2018-02-09T18:31:28Z MEMBER

@apatlpo sure, something like: ```python import threading import matplotlib.pyplot

MPL_LOCK = threading.Lock()

def save_imshow(data, path): with MPL_LOCK: fig, ax = plt.subplot() ax.imshow(data) fig.savefig(path) ``save_imshow()is now something you safely call in parallel (e.g., fromdask.array.map_blocks()`).

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   call to colorbar not thread safe 294735496
363601313 https://github.com/pydata/xarray/issues/1889#issuecomment-363601313 https://api.github.com/repos/pydata/xarray/issues/1889 MDEyOklzc3VlQ29tbWVudDM2MzYwMTMxMw== shoyer 1217238 2018-02-06T23:26:49Z 2018-02-06T23:26:55Z MEMBER

I agree that it is certainly a best practice to avoid relying on global state from the pyplot module.

That said, my experience has been that even if you avoid using pyplot functions matplotlib is still not thread-safe (StackOverflow backs me up here). So you probably will need a thread-lock around your use of any plotting functions, anyways.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   call to colorbar not thread safe 294735496

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);