issue_comments

Table actions

13 rows where issue = 293830986 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: created_at (date), updated_at (date)

author_association 2

issue 1

  • Explicit listing of optional dependencies · 13 ✖
id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
362942383 https://github.com/pydata/xarray/issues/1879#issuecomment-362942383 https://api.github.com/repos/pydata/xarray/issues/1879 MDEyOklzc3VlQ29tbWVudDM2Mjk0MjM4Mw== shoyer 1217238 2018-02-04T21:42:33Z 2018-02-04T21:42:33Z MEMBER

What about toolz used by auto_combine?

toolz should probably be listed explicitly as an optional dependencies, but I didn't bother since it's a hard dependency of dask.array, and we only use toolz in cases where dask.array is also required. (In theory, dask.array could drop its use of toolz internally, but that's unlikely to happen anytime soon.)

For instance, given a feature with multiple backends, the dependencies for the preferred backend should be recommended, whilst the others should just be suggested.

I don't think the difference between recommended and suggested dependencies is relevant for xarray. We don't have any features with multiple backends where a single backend is strictly preferred.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Explicit listing of optional dependencies 293830986
362793230 https://github.com/pydata/xarray/issues/1879#issuecomment-362793230 https://api.github.com/repos/pydata/xarray/issues/1879 MDEyOklzc3VlQ29tbWVudDM2Mjc5MzIzMA== ghisvail 1964655 2018-02-03T09:24:19Z 2018-02-03T09:24:19Z CONTRIBUTOR

I guess that by your definition it would be suggested?

Correct.

Is rasterio going to make it to debian as an apt package?

That's already the case, see: https://packages.debian.org/source/sid/rasterio

What about toolz used by auto_combine?

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Explicit listing of optional dependencies 293830986
362716724 https://github.com/pydata/xarray/issues/1879#issuecomment-362716724 https://api.github.com/repos/pydata/xarray/issues/1879 MDEyOklzc3VlQ29tbWVudDM2MjcxNjcyNA== fmaussion 10050469 2018-02-02T21:44:38Z 2018-02-02T21:44:38Z MEMBER

rasterio is only required if you want to open a specific type of files (geotiffs): the vast majority of our users won't touch open_rasterio. I guess that by your definition it would be suggested? Is rasterio going to make it to debian as an apt package?

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Explicit listing of optional dependencies 293830986
362712709 https://github.com/pydata/xarray/issues/1879#issuecomment-362712709 https://api.github.com/repos/pydata/xarray/issues/1879 MDEyOklzc3VlQ29tbWVudDM2MjcxMjcwOQ== ghisvail 1964655 2018-02-02T21:27:40Z 2018-02-02T21:27:40Z CONTRIBUTOR

Well, I am considering (perhaps wrongly) what's in xarray/__init__.py as the public API of xarray. With that logic in mind, any unconditional import should be treated as an install dependency. Otherwise, users will indeed get an ImportError which is not very good.

Back to the original topic, should toolz and rasterio be strict dependencies, recommended or suggested then?

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Explicit listing of optional dependencies 293830986
362711490 https://github.com/pydata/xarray/issues/1879#issuecomment-362711490 https://api.github.com/repos/pydata/xarray/issues/1879 MDEyOklzc3VlQ29tbWVudDM2MjcxMTQ5MA== fmaussion 10050469 2018-02-02T21:22:29Z 2018-02-02T21:22:29Z MEMBER

arguably, we could catch the import error and send a more informative error message

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Explicit listing of optional dependencies 293830986
362711044 https://github.com/pydata/xarray/issues/1879#issuecomment-362711044 https://api.github.com/repos/pydata/xarray/issues/1879 MDEyOklzc3VlQ29tbWVudDM2MjcxMTA0NA== fmaussion 10050469 2018-02-02T21:20:45Z 2018-02-02T21:20:45Z MEMBER

open_rasterio is also exposed by xarray/init.py and imports rasterio unconditionally

I don't understand what you mean: as long as open_rasterio is not called by the user, rasterio doesn't need to be installed?

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Explicit listing of optional dependencies 293830986
362709426 https://github.com/pydata/xarray/issues/1879#issuecomment-362709426 https://api.github.com/repos/pydata/xarray/issues/1879 MDEyOklzc3VlQ29tbWVudDM2MjcwOTQyNg== ghisvail 1964655 2018-02-02T21:14:13Z 2018-02-02T21:14:13Z CONTRIBUTOR

And open_rasterio is also exposed by xarray/__init__.py and imports rasterio unconditionally. So again, that makes rasterio an install_requires too.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Explicit listing of optional dependencies 293830986
362708442 https://github.com/pydata/xarray/issues/1879#issuecomment-362708442 https://api.github.com/repos/pydata/xarray/issues/1879 MDEyOklzc3VlQ29tbWVudDM2MjcwODQ0Mg== ghisvail 1964655 2018-02-02T21:10:27Z 2018-02-02T21:10:27Z CONTRIBUTOR

Indeed. xarray/__init__.py does import auto_combine from xarray/core/combine.py, so toolz should be listed as install_depends I guess.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Explicit listing of optional dependencies 293830986
362707931 https://github.com/pydata/xarray/issues/1879#issuecomment-362707931 https://api.github.com/repos/pydata/xarray/issues/1879 MDEyOklzc3VlQ29tbWVudDM2MjcwNzkzMQ== fmaussion 10050469 2018-02-02T21:08:29Z 2018-02-02T21:08:29Z MEMBER

yes, this list seems a bit outdated. rasterio should be mentioned too.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Explicit listing of optional dependencies 293830986
362707544 https://github.com/pydata/xarray/issues/1879#issuecomment-362707544 https://api.github.com/repos/pydata/xarray/issues/1879 MDEyOklzc3VlQ29tbWVudDM2MjcwNzU0NA== ghisvail 1964655 2018-02-02T21:06:49Z 2018-02-02T21:06:49Z CONTRIBUTOR

And what about toolz which is used in xarray/core/combine.py?

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Explicit listing of optional dependencies 293830986
362706653 https://github.com/pydata/xarray/issues/1879#issuecomment-362706653 https://api.github.com/repos/pydata/xarray/issues/1879 MDEyOklzc3VlQ29tbWVudDM2MjcwNjY1Mw== max-sixty 5635139 2018-02-02T21:03:12Z 2018-02-02T21:03:12Z MEMBER

its description says it is obsolete.

obsolete on python 3.5+

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Explicit listing of optional dependencies 293830986
362705948 https://github.com/pydata/xarray/issues/1879#issuecomment-362705948 https://api.github.com/repos/pydata/xarray/issues/1879 MDEyOklzc3VlQ29tbWVudDM2MjcwNTk0OA== ghisvail 1964655 2018-02-02T21:00:25Z 2018-02-02T21:00:25Z CONTRIBUTOR

So, just to confirm, the recommended dependencies are just dask, netCDF4 and bottleneck, right? The rest should be suggested.

What about cyordereddict? It is listed in the docs but its description says it is obsolete.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Explicit listing of optional dependencies 293830986
362646366 https://github.com/pydata/xarray/issues/1879#issuecomment-362646366 https://api.github.com/repos/pydata/xarray/issues/1879 MDEyOklzc3VlQ29tbWVudDM2MjY0NjM2Ng== jhamman 2443309 2018-02-02T17:13:25Z 2018-02-02T17:13:25Z MEMBER 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Explicit listing of optional dependencies 293830986

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);