issue_comments

Table actions

2 rows where issue = 293414745 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: created_at (date), updated_at (date)

user 2

issue 1

  • DEP: drop Python 2.7 support · 2 ✖

author_association 1

id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
365746775 https://github.com/pydata/xarray/issues/1876#issuecomment-365746775 https://api.github.com/repos/pydata/xarray/issues/1876 MDEyOklzc3VlQ29tbWVudDM2NTc0Njc3NQ== jhamman 2443309 2018-02-14T21:13:13Z 2018-02-14T21:13:13Z MEMBER

A practical change we need to make prior to dropping python 2 is to move the Python 2 test suite to Python 3. A number of Xarray's optional dependencies are still pinned to Python 2 so there will be a few hiccups there:

Ideally, we can just map the py2 tests directly to py3:

  • py27-min --> py35-min
  • py27-cdat+iris+pynio --> py36-cdat+iris+pynio

We may also consider dropping this test all together and putting cdat/iris/pynio in the standard py36 test.

 
{
    "total_count": 1,
    "+1": 1,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   DEP: drop Python 2.7 support 293414745
362185062 https://github.com/pydata/xarray/issues/1876#issuecomment-362185062 https://api.github.com/repos/pydata/xarray/issues/1876 MDEyOklzc3VlQ29tbWVudDM2MjE4NTA2Mg== fmaussion 10050469 2018-02-01T07:48:39Z 2018-02-01T07:48:39Z MEMBER

Thanks! The practicalities page from the python3statement is a good start.

What I heard from other projects is that we shouldn't actively remove cross-compatible code. We could simply stop testing on py2 and not care about cross-compatibility anymore. 

{
    "total_count": 2,
    "+1": 2,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   DEP: drop Python 2.7 support 293414745

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);