issue_comments

Table actions

11 rows where issue = 29220463 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: created_at (date), updated_at (date)

user 3

author_association 2

issue 1

  • Modified Dataset.replace to replace a dictionary of variables · 11 ✖
id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
39058527 https://github.com/pydata/xarray/pull/62#issuecomment-39058527 https://api.github.com/repos/pydata/xarray/issues/62 MDEyOklzc3VlQ29tbWVudDM5MDU4NTI3 shoyer 1217238 2014-03-31T06:57:38Z 2014-03-31T06:57:38Z MEMBER

Replaced by #87.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Modified Dataset.replace to replace a dictionary of variables 29220463
37435670 https://github.com/pydata/xarray/pull/62#issuecomment-37435670 https://api.github.com/repos/pydata/xarray/issues/62 MDEyOklzc3VlQ29tbWVudDM3NDM1Njcw akleeman 514053 2014-03-12T17:10:58Z 2014-03-12T17:10:58Z CONTRIBUTOR

Renaming set_variables to update seems reasonable to me. Its behavior seems similar enough to dict.update. Then a separate function replace could be a lightweight wrapper around update which makes a copy:

obj = type(self)(variables, self.attributes) obj.update(_args, *_kwdargs)

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Modified Dataset.replace to replace a dictionary of variables 29220463
37432906 https://github.com/pydata/xarray/pull/62#issuecomment-37432906 https://api.github.com/repos/pydata/xarray/issues/62 MDEyOklzc3VlQ29tbWVudDM3NDMyOTA2 ebrevdo 1794715 2014-03-12T16:50:18Z 2014-03-12T16:50:18Z CONTRIBUTOR

I definitely like the inplace idea. We could also use the function name update in this case. On Mar 12, 2014 9:49 AM, "Stephan Hoyer" notifications@github.com wrote:

I'm thinking now that we should move Dataset.replace into Dataset.set_variables, with the keyword argument "inplace" (like Dataset.merge). This would consolidate the public interface (which is usually a good thing).

Reply to this email directly or view it on GitHubhttps://github.com/akleeman/xray/pull/62#issuecomment-37432745 .

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Modified Dataset.replace to replace a dictionary of variables 29220463
37432745 https://github.com/pydata/xarray/pull/62#issuecomment-37432745 https://api.github.com/repos/pydata/xarray/issues/62 MDEyOklzc3VlQ29tbWVudDM3NDMyNzQ1 shoyer 1217238 2014-03-12T16:49:05Z 2014-03-12T16:49:05Z MEMBER

I'm thinking now that we should move Dataset.replace into Dataset.set_variables, with the keyword argument "inplace" (like Dataset.merge). This would consolidate the public interface (which is usually a good thing).

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Modified Dataset.replace to replace a dictionary of variables 29220463
37376646 https://github.com/pydata/xarray/pull/62#issuecomment-37376646 https://api.github.com/repos/pydata/xarray/issues/62 MDEyOklzc3VlQ29tbWVudDM3Mzc2NjQ2 ebrevdo 1794715 2014-03-12T05:24:06Z 2014-03-12T05:24:06Z CONTRIBUTOR

True. Maybe stick with replace, and we can put filter on the to do? I may work on it tomorrow. On Mar 11, 2014 10:10 PM, "Stephan Hoyer" notifications@github.com wrote:

Yes, I suppose update would be an appropriate name -- except update strongly conveys (to me) that the operation is done in place (like how it works for Python dicts).

Reply to this email directly or view it on GitHubhttps://github.com/akleeman/xray/pull/62#issuecomment-37376178 .

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Modified Dataset.replace to replace a dictionary of variables 29220463
37376178 https://github.com/pydata/xarray/pull/62#issuecomment-37376178 https://api.github.com/repos/pydata/xarray/issues/62 MDEyOklzc3VlQ29tbWVudDM3Mzc2MTc4 shoyer 1217238 2014-03-12T05:10:45Z 2014-03-12T05:10:45Z MEMBER

Yes, I suppose update would be an appropriate name -- except update strongly conveys (to me) that the operation is done in place (like how it works for Python dicts).

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Modified Dataset.replace to replace a dictionary of variables 29220463
37375935 https://github.com/pydata/xarray/pull/62#issuecomment-37375935 https://api.github.com/repos/pydata/xarray/issues/62 MDEyOklzc3VlQ29tbWVudDM3Mzc1OTM1 ebrevdo 1794715 2014-03-12T05:05:00Z 2014-03-12T05:05:00Z CONTRIBUTOR

Don't dicts have an update function that works this way? On Mar 11, 2014 9:48 PM, "Stephan Hoyer" notifications@github.com wrote:

Perhaps this method should be called "modify" instead of "replace", since it also lets you set or remove variables. Thoughts?

Reply to this email directly or view it on GitHubhttps://github.com/akleeman/xray/pull/62#issuecomment-37375305 .

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Modified Dataset.replace to replace a dictionary of variables 29220463
37375305 https://github.com/pydata/xarray/pull/62#issuecomment-37375305 https://api.github.com/repos/pydata/xarray/issues/62 MDEyOklzc3VlQ29tbWVudDM3Mzc1MzA1 shoyer 1217238 2014-03-12T04:48:51Z 2014-03-12T04:48:51Z MEMBER

Perhaps this method should be called "modify" instead of "replace", since it also lets you set or remove variables. Thoughts?

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Modified Dataset.replace to replace a dictionary of variables 29220463
37358215 https://github.com/pydata/xarray/pull/62#issuecomment-37358215 https://api.github.com/repos/pydata/xarray/issues/62 MDEyOklzc3VlQ29tbWVudDM3MzU4MjE1 ebrevdo 1794715 2014-03-11T23:13:12Z 2014-03-11T23:13:12Z CONTRIBUTOR

This in response to your first bullet:

Create a new dataset based on some (but not all) variables from an existing dataset.

for that there's a filter() in pandas. it would be useful to have here as well.

On Tue, Mar 11, 2014 at 4:11 PM, Stephan Hoyer notifications@github.comwrote:

Not really. A filter method would be a useful addition for xray, but Dataset.replace is replacing entire variables, not values in variable.

Reply to this email directly or view it on GitHubhttps://github.com/akleeman/xray/pull/62#issuecomment-37358060 .

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Modified Dataset.replace to replace a dictionary of variables 29220463
37358060 https://github.com/pydata/xarray/pull/62#issuecomment-37358060 https://api.github.com/repos/pydata/xarray/issues/62 MDEyOklzc3VlQ29tbWVudDM3MzU4MDYw shoyer 1217238 2014-03-11T23:11:11Z 2014-03-11T23:11:11Z MEMBER

Not really. A filter method would be a useful addition for xray, but Dataset.replace is replacing entire variables, not values in variable.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Modified Dataset.replace to replace a dictionary of variables 29220463
37354993 https://github.com/pydata/xarray/pull/62#issuecomment-37354993 https://api.github.com/repos/pydata/xarray/issues/62 MDEyOklzc3VlQ29tbWVudDM3MzU0OTkz ebrevdo 1794715 2014-03-11T22:36:32Z 2014-03-11T22:36:32Z CONTRIBUTOR

Is part 1 similar to the pandas .filter operator? That one has nice keywords, 'like', 'regex', etc.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Modified Dataset.replace to replace a dictionary of variables 29220463

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);