issue_comments

Table actions

3 rows where issue = 291405750 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: created_at (date), updated_at (date)

user 2

issue 1

  • swap_dims should support dimension names that are not existing variables · 3 ✖

author_association 1

id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
566780123 https://github.com/pydata/xarray/issues/1855#issuecomment-566780123 https://api.github.com/repos/pydata/xarray/issues/1855 MDEyOklzc3VlQ29tbWVudDU2Njc4MDEyMw== keewis 14808389 2019-12-17T22:35:17Z 2019-12-18T00:35:59Z MEMBER

we should, however, clearly define the use cases of swap_dims and rename_dims. Right now, the docs are not really clear on the difference between them.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   swap_dims should support dimension names that are not existing variables 291405750
566601068 https://github.com/pydata/xarray/issues/1855#issuecomment-566601068 https://api.github.com/repos/pydata/xarray/issues/1855 MDEyOklzc3VlQ29tbWVudDU2NjYwMTA2OA== keewis 14808389 2019-12-17T15:50:39Z 2019-12-17T22:35:47Z MEMBER

I think rename_dims does something different: it renames a dimension if the new name does not exist (if it exists, it does something strange, see #3438), while swap_dims creates a new dimension and moves the old dimension to coords (or data_vars?).

Edit: I don't have a strong opinion, though

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   swap_dims should support dimension names that are not existing variables 291405750
566598314 https://github.com/pydata/xarray/issues/1855#issuecomment-566598314 https://api.github.com/repos/pydata/xarray/issues/1855 MDEyOklzc3VlQ29tbWVudDU2NjU5ODMxNA== dcherian 2448579 2019-12-17T15:45:05Z 2019-12-17T15:45:05Z MEMBER

I think we already have this as ds.rename_dims?

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   swap_dims should support dimension names that are not existing variables 291405750

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);