issue_comments

Table actions

3 rows where issue = 291103680 and user = 1386642 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: created_at (date), updated_at (date)

user 1

  • nbren12 · 3 ✖

issue 1

  • bug: 2D pcolormesh plots are wrong when coordinate is not ascending order · 3 ✖

author_association 1

id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
360232940 https://github.com/pydata/xarray/issues/1852#issuecomment-360232940 https://api.github.com/repos/pydata/xarray/issues/1852 MDEyOklzc3VlQ29tbWVudDM2MDIzMjk0MA== nbren12 1386642 2018-01-24T18:42:58Z 2018-01-24T18:42:58Z CONTRIBUTOR

I think automatically sorting is OK for 1D coordinates at least. I agree it is more complicated for other situations.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   bug: 2D pcolormesh plots are wrong when coordinate is not ascending order 291103680
360230869 https://github.com/pydata/xarray/issues/1852#issuecomment-360230869 https://api.github.com/repos/pydata/xarray/issues/1852 MDEyOklzc3VlQ29tbWVudDM2MDIzMDg2OQ== nbren12 1386642 2018-01-24T18:36:12Z 2018-01-24T18:36:19Z CONTRIBUTOR

pcolormesh expects n+1 coordinates

I agree that pcolormesh ultimately works with the mesh corners, but I am pretty sure passing coordinates of the same length also works.

you'll probably have to sort the values beforehand too

True. But we can do it automatically with xarray because it has the coordinate information.

So the question is how much sanity check xarray should do before sending the data to matplotlib, and maybe a warning of some kind would be useful.

I am not sure there there is any circumstance where it would be preferable to plot the scrambled data. Is there some the problem with just adding something like the two lines a wrote above to plot.pcolormesh?

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   bug: 2D pcolormesh plots are wrong when coordinate is not ascending order 291103680
360039440 https://github.com/pydata/xarray/issues/1852#issuecomment-360039440 https://api.github.com/repos/pydata/xarray/issues/1852 MDEyOklzc3VlQ29tbWVudDM2MDAzOTQ0MA== nbren12 1386642 2018-01-24T07:03:00Z 2018-01-24T07:03:12Z CONTRIBUTOR

This is pretty easily fixed running python sort_inds = {dim: np.argsort(z[dim].values) for dim in z.dims} z = z.isel(**sort_inds)

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   bug: 2D pcolormesh plots are wrong when coordinate is not ascending order 291103680

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);