home / github

Menu
  • GraphQL API
  • Search all tables

issue_comments

Table actions
  • GraphQL API for issue_comments

5 rows where issue = 291103680 and user = 10050469 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: created_at (date), updated_at (date)

user 1

  • fmaussion · 5 ✖

issue 1

  • bug: 2D pcolormesh plots are wrong when coordinate is not ascending order · 5 ✖

author_association 1

  • MEMBER 5
id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
360284982 https://github.com/pydata/xarray/issues/1852#issuecomment-360284982 https://api.github.com/repos/pydata/xarray/issues/1852 MDEyOklzc3VlQ29tbWVudDM2MDI4NDk4Mg== fmaussion 10050469 2018-01-24T21:48:41Z 2018-01-24T21:48:41Z MEMBER

Rather than automatically sorting data, we could start raising an error if labels are unsorted.

yes, I prefer that too.

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
  bug: 2D pcolormesh plots are wrong when coordinate is not ascending order 291103680
360284536 https://github.com/pydata/xarray/issues/1852#issuecomment-360284536 https://api.github.com/repos/pydata/xarray/issues/1852 MDEyOklzc3VlQ29tbWVudDM2MDI4NDUzNg== fmaussion 10050469 2018-01-24T21:46:58Z 2018-01-24T21:46:58Z MEMBER

I agree that pcolormesh ultimately works with the mesh corners, I am pretty sure passing coordinates of the same length also works.

Passing N coordinates will crop the data of one pixel and plot N-1 pixels. For example:

```python import matplotlib.pyplot as plt

data = [[1, 2], [3, 4]] f, (ax1, ax2) = plt.subplots(1, 2) ax1.pcolormesh([1, 2, 3], [2, 3, 4], data) ax1.set_title('N+1 coords') ax2.pcolormesh([1, 2], [2, 3], data) ax2.set_title('N coords') plt.savefig('example.png') ```

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
  bug: 2D pcolormesh plots are wrong when coordinate is not ascending order 291103680
360282925 https://github.com/pydata/xarray/issues/1852#issuecomment-360282925 https://api.github.com/repos/pydata/xarray/issues/1852 MDEyOklzc3VlQ29tbWVudDM2MDI4MjkyNQ== fmaussion 10050469 2018-01-24T21:41:23Z 2018-01-24T21:41:23Z MEMBER

... But I guess that you're right, it should be fine to do as you suggest!

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
  bug: 2D pcolormesh plots are wrong when coordinate is not ascending order 291103680
360281631 https://github.com/pydata/xarray/issues/1852#issuecomment-360281631 https://api.github.com/repos/pydata/xarray/issues/1852 MDEyOklzc3VlQ29tbWVudDM2MDI4MTYzMQ== fmaussion 10050469 2018-01-24T21:36:42Z 2018-01-24T21:36:42Z MEMBER

Is there some the problem with just adding something like the two lines a wrote above to plot.pcolormesh?

Performance I guess, and the fact that monotonically descending coordinates also work fine. I don't think this happens very often so sorting and calling isel on every single array is overkill.

I don't have a strong opinion here, so I'll let @shoyer or others decide what's best.

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
  bug: 2D pcolormesh plots are wrong when coordinate is not ascending order 291103680
360146186 https://github.com/pydata/xarray/issues/1852#issuecomment-360146186 https://api.github.com/repos/pydata/xarray/issues/1852 MDEyOklzc3VlQ29tbWVudDM2MDE0NjE4Ng== fmaussion 10050469 2018-01-24T14:07:16Z 2018-01-24T14:07:16Z MEMBER

It's not a trivial problem, because pcolormesh expects n+1 coordinates (the coordinates of the mesh corners), and to do what you want with matplotlib's pcolormesh alone (i.e. without xarray), you'll probably have to sort the values beforehand too (correct me if I'm wrong).

So the question is how much sanity check xarray should do before sending the data to matplotlib, and maybe a warning of some kind would be useful. Xarray's pcolormeh already implements some logic to make it easier to use than matplotlib's (see e.g. https://github.com/pydata/xarray/pull/1079).

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
  bug: 2D pcolormesh plots are wrong when coordinate is not ascending order 291103680

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options:

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);
Powered by Datasette · Queries took 42.778ms · About: xarray-datasette