issue_comments

Table actions

11 rows where issue = 288365213 and user = 5635139 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: reactions, created_at (date), updated_at (date)

user 1

  • max-sixty · 11 ✖

issue 1

  • Align DataArrays based on coords in Dataset constructor · 11 ✖

author_association 1

id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
393366280 https://github.com/pydata/xarray/pull/1826#issuecomment-393366280 https://api.github.com/repos/pydata/xarray/issues/1826 MDEyOklzc3VlQ29tbWVudDM5MzM2NjI4MA== max-sixty 5635139 2018-05-31T00:53:25Z 2018-05-31T00:53:25Z MEMBER

Thanks @shoyer !

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Align DataArrays based on coords in Dataset constructor 288365213
393332974 https://github.com/pydata/xarray/pull/1826#issuecomment-393332974 https://api.github.com/repos/pydata/xarray/issues/1826 MDEyOklzc3VlQ29tbWVudDM5MzMzMjk3NA== max-sixty 5635139 2018-05-30T21:56:52Z 2018-05-30T21:56:52Z MEMBER

Gentlest of pings (but tell me if pings are not helpful - especially given I disappear for a few weeks)

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Align DataArrays based on coords in Dataset constructor 288365213
392597483 https://github.com/pydata/xarray/pull/1826#issuecomment-392597483 https://api.github.com/repos/pydata/xarray/issues/1826 MDEyOklzc3VlQ29tbWVudDM5MjU5NzQ4Mw== max-sixty 5635139 2018-05-28T20:18:30Z 2018-05-28T20:19:03Z MEMBER

I've updated this.

My penultimate commit was a simple copy/paste of @shoyer recommended approach. The final commit is the same approach at a slightly different point in the call stack, which I think is better encapsulated. But - as ever - v open to feedback

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Align DataArrays based on coords in Dataset constructor 288365213
377664335 https://github.com/pydata/xarray/pull/1826#issuecomment-377664335 https://api.github.com/repos/pydata/xarray/issues/1826 MDEyOklzc3VlQ29tbWVudDM3NzY2NDMzNQ== max-sixty 5635139 2018-03-31T04:11:06Z 2018-03-31T04:11:06Z MEMBER

@shoyer gentlest of pings

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Align DataArrays based on coords in Dataset constructor 288365213
377035720 https://github.com/pydata/xarray/pull/1826#issuecomment-377035720 https://api.github.com/repos/pydata/xarray/issues/1826 MDEyOklzc3VlQ29tbWVudDM3NzAzNTcyMA== max-sixty 5635139 2018-03-28T21:03:24Z 2018-03-28T21:03:24Z MEMBER

Green @shoyer

But do let me know if this may still be missing something

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Align DataArrays based on coords in Dataset constructor 288365213
376739482 https://github.com/pydata/xarray/pull/1826#issuecomment-376739482 https://api.github.com/repos/pydata/xarray/issues/1826 MDEyOklzc3VlQ29tbWVudDM3NjczOTQ4Mg== max-sixty 5635139 2018-03-28T02:28:40Z 2018-03-28T02:29:00Z MEMBER

I think tests are failing for other reasons? https://travis-ci.org/maxim-lian/xarray/builds/359165503

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Align DataArrays based on coords in Dataset constructor 288365213
370119540 https://github.com/pydata/xarray/pull/1826#issuecomment-370119540 https://api.github.com/repos/pydata/xarray/issues/1826 MDEyOklzc3VlQ29tbWVudDM3MDExOTU0MA== max-sixty 5635139 2018-03-03T05:10:42Z 2018-03-03T05:10:42Z MEMBER

@shoyer Green!

Is that what you were thinking re the additional tests? Lmk if more would be helpful

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Align DataArrays based on coords in Dataset constructor 288365213
368389025 https://github.com/pydata/xarray/pull/1826#issuecomment-368389025 https://api.github.com/repos/pydata/xarray/issues/1826 MDEyOklzc3VlQ29tbWVudDM2ODM4OTAyNQ== max-sixty 5635139 2018-02-26T04:46:32Z 2018-02-26T04:46:32Z MEMBER

@shoyer any feedback?

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Align DataArrays based on coords in Dataset constructor 288365213
366839865 https://github.com/pydata/xarray/pull/1826#issuecomment-366839865 https://api.github.com/repos/pydata/xarray/issues/1826 MDEyOklzc3VlQ29tbWVudDM2NjgzOTg2NQ== max-sixty 5635139 2018-02-20T01:14:10Z 2018-02-20T01:14:10Z MEMBER

@shoyer ready for review

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Align DataArrays based on coords in Dataset constructor 288365213
364500636 https://github.com/pydata/xarray/pull/1826#issuecomment-364500636 https://api.github.com/repos/pydata/xarray/issues/1826 MDEyOklzc3VlQ29tbWVudDM2NDUwMDYzNg== max-sixty 5635139 2018-02-09T17:25:42Z 2018-02-09T17:25:42Z MEMBER

This is much simpler than I expected - have I missed something basic here?

Yes I had.

I've spent some time working through some cases and tripped myself up a few times.

Still working on it (though mainly when I'm on a plane). If I can't resolve some issues I may post some questions here

 
{
    "total_count": 1,
    "+1": 1,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Align DataArrays based on coords in Dataset constructor 288365213
357472742 https://github.com/pydata/xarray/pull/1826#issuecomment-357472742 https://api.github.com/repos/pydata/xarray/issues/1826 MDEyOklzc3VlQ29tbWVudDM1NzQ3Mjc0Mg== max-sixty 5635139 2018-01-13T22:36:21Z 2018-01-13T22:36:21Z MEMBER

This is much simpler than I expected - have I missed something basic here?

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Align DataArrays based on coords in Dataset constructor 288365213

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);