home / github

Menu
  • GraphQL API
  • Search all tables

issue_comments

Table actions
  • GraphQL API for issue_comments

11 rows where issue = 287852184 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: reactions, created_at (date), updated_at (date)

user 6

  • shoyer 4
  • jhamman 2
  • Zac-HD 2
  • rabernat 1
  • dcherian 1
  • czr137 1

author_association 2

  • MEMBER 8
  • CONTRIBUTOR 3

issue 1

  • v0.10.1 Release · 11 ✖
id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
368686954 https://github.com/pydata/xarray/issues/1821#issuecomment-368686954 https://api.github.com/repos/pydata/xarray/issues/1821 MDEyOklzc3VlQ29tbWVudDM2ODY4Njk1NA== Zac-HD 12229877 2018-02-26T23:20:45Z 2018-02-26T23:20:45Z CONTRIBUTOR

First: thanks, everyone, for such a prompt and helpful response! I'm excited both to have 10.1 (:tada:), and by the prospect of faster/automated releases in future.

Reading over the releasing instructions, I think there are three parts we need to work on to go fully automated. By fully automated, I mean "no maintainer action whatsoever beyond merging pulls, which are not release-specific":

  • Most things can be automated with continuous deployment scripts like Hypothesis'. We deploy a patch or minor release for every pull request, but if that's undesirable you could run the deployment from a weekly "cron" job on Travis.
  • Changelog management (for weekly rather than per-PR releases) can be automated with https://github.com/hawkowl/towncrier - there's a substitute for all of us :smile:
  • Xarray would need some novel scripts for uploading Github releases and driving the conda-forge feedstock. (Which Hypothesis would borrow in turn - it's lower priority for us but still nice to have)

In short, my advice is to be creative, and if release processes can't be automated - change them!

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
  v0.10.1 Release 287852184
368540882 https://github.com/pydata/xarray/issues/1821#issuecomment-368540882 https://api.github.com/repos/pydata/xarray/issues/1821 MDEyOklzc3VlQ29tbWVudDM2ODU0MDg4Mg== rabernat 1197350 2018-02-26T15:30:45Z 2018-02-26T15:30:45Z MEMBER

@Zac-HD: I hear your frustration! Thanks for putting some much needed pressure on this community to move to a faster release cycle. I think xarray is experiencing some growing pains as adoption increases. I generally favor automating as much as possible, modulo the necessary manual checks described by @shoyer.

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
  v0.10.1 Release 287852184
368367665 https://github.com/pydata/xarray/issues/1821#issuecomment-368367665 https://api.github.com/repos/pydata/xarray/issues/1821 MDEyOklzc3VlQ29tbWVudDM2ODM2NzY2NQ== shoyer 1217238 2018-02-26T01:48:25Z 2018-02-26T01:48:25Z MEMBER

My messing around with tags seems to have been successful. The docs successfully build and been updated: http://xarray.pydata.org/en/stable/whats-new.html

It looks like the conda-forge update is also in progress: https://github.com/conda-forge/xarray-feedstock/pull/27 (thanks @jhamman and @ocefpaf !)

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
  v0.10.1 Release 287852184
368362084 https://github.com/pydata/xarray/issues/1821#issuecomment-368362084 https://api.github.com/repos/pydata/xarray/issues/1821 MDEyOklzc3VlQ29tbWVudDM2ODM2MjA4NA== shoyer 1217238 2018-02-26T00:54:15Z 2018-02-26T00:54:22Z MEMBER

I'm going to push another version of the 0.10.1 tag to GitHub that includes fixes to doc/environment.yml (https://github.com/pydata/xarray/commit/20207fd45280a3cb0f2ca3bdef693f47b1880dca and https://github.com/pydata/xarray/commit/f530e668fa50665245988be2a00748b9b3ccc0a8).

This will allow us to actually build docs for 0.10.1 on ReadTheDocs.

{
    "total_count": 1,
    "+1": 1,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
  v0.10.1 Release 287852184
368361385 https://github.com/pydata/xarray/issues/1821#issuecomment-368361385 https://api.github.com/repos/pydata/xarray/issues/1821 MDEyOklzc3VlQ29tbWVudDM2ODM2MTM4NQ== jhamman 2443309 2018-02-26T00:45:00Z 2018-02-26T00:45:00Z MEMBER

@shoyer - I can do the conda-forge update.

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
  v0.10.1 Release 287852184
368360707 https://github.com/pydata/xarray/issues/1821#issuecomment-368360707 https://api.github.com/repos/pydata/xarray/issues/1821 MDEyOklzc3VlQ29tbWVudDM2ODM2MDcwNw== shoyer 1217238 2018-02-26T00:38:19Z 2018-02-26T00:38:19Z MEMBER

I just pushed the release to pypi.

I'm dealing with the RTD build now, which seems to have broken without us noticing!

{
    "total_count": 1,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 1,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
  v0.10.1 Release 287852184
368359451 https://github.com/pydata/xarray/issues/1821#issuecomment-368359451 https://api.github.com/repos/pydata/xarray/issues/1821 MDEyOklzc3VlQ29tbWVudDM2ODM1OTQ1MQ== jhamman 2443309 2018-02-26T00:22:29Z 2018-02-26T00:22:29Z MEMBER

I'm a enthusiastic 👍 for getting this release out ASAP and generally releasing more regularly. I take some of the blame for moving the goalposts for this release, particularly with regard to #1464.

@shoyer - please go forward with the release and let me know if you need a hand with anything.

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
  v0.10.1 Release 287852184
368347844 https://github.com/pydata/xarray/issues/1821#issuecomment-368347844 https://api.github.com/repos/pydata/xarray/issues/1821 MDEyOklzc3VlQ29tbWVudDM2ODM0Nzg0NA== shoyer 1217238 2018-02-25T21:46:40Z 2018-02-25T21:46:40Z MEMBER

@Zac-HD Thanks for raising these concerns! I agree there are only upsides to a faster release cycle, and three months is way too long given the long back-log of improvements we have. Even without more automation, we should not wait more than 2-4 weeks between releases unless there are breaking changes in process (which can sometimes require more refinement to get right).

I think the trouble is that it's easy to get in a bad pattern of waiting for "just one more pull request" before issuing a new release. This is self-reinforcing -- the fewer releases we have, the more important it is to wait for a pull request before issuing a release.

I'd love to explore a more automated release pipeline. Take a look here for our current release instructions: https://github.com/pydata/xarray/blob/master/HOW_TO_RELEASE

In my experience, the slowest step is clean-ups/fixes of the "what's new" docs page (e.g., what I just did in https://github.com/pydata/xarray/pull/1940). It's hard to do that as part of the regular PR process in part because we only see built docs after PRs are merged. That said, if we do this more regularly the work required decreases (I spent about half an hour on this today). Unfortunately, there is no automated substitute for a human looking over a document to verify that it looks right :).

The actual release issuing process is quite fast once you know what you're doing, taking as little as half an hour minutes to update pypi, ReadTheDocs and conda-forge. But it would certainly be great if anyone (even non-maintainers) is capable of triggering this with a simple PR. Ideally, we should be able to issue a release anytime someone is willing to put in the effort of looking things over and ensuring the docs look right.

Anyways, my plan is to issue a release later today or tomorrow, as soon as #1940 is merged. There are lots of other excellent improvements in the pipeline (rolling window improvements, distributed writes to netCDF files, etc.) but we should just issue another release when those get merged instead of holding things up!

{
    "total_count": 3,
    "+1": 1,
    "-1": 0,
    "laugh": 0,
    "hooray": 1,
    "confused": 0,
    "heart": 1,
    "rocket": 0,
    "eyes": 0
}
  v0.10.1 Release 287852184
368303298 https://github.com/pydata/xarray/issues/1821#issuecomment-368303298 https://api.github.com/repos/pydata/xarray/issues/1821 MDEyOklzc3VlQ29tbWVudDM2ODMwMzI5OA== Zac-HD 12229877 2018-02-25T11:55:31Z 2018-02-25T11:55:31Z CONTRIBUTOR

@jhamman & @shoyer - I think Xarray has a release frequency problem.

  • 1782 has been merged, but I still can't plot timeseries with an all-nan step

  • 1796, #1819, and #1893 have been merged - but I still can't plot RGB images

  • 1840 has been merged - but loading CF-int-encoded data still uses double the memory it needs.

  • All of these daily tasks for myself and my colleagues are harder than they should be.

It's been more than three months now without a patch release. This is really, really frustrating as an Xarray contributor, user, and advocate - getting my work merged upstream literally isn't worth anything until it's released, my colleagues have trouble using it (and go back to Matlab or IDL!), and it's harder to ask for anything in meetings with eg @opendatacube.

Moving to weekly patch releases would fix all of these problems.

Maintainer availability doesn't need to be a limiting factor, either - for example, @HypothesisWorks has a deployment pipeline where the only human involvement is to click 'merge', and I'd be happy to help out if you'd like to set up a similar system.

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
  v0.10.1 Release 287852184
365352132 https://github.com/pydata/xarray/issues/1821#issuecomment-365352132 https://api.github.com/repos/pydata/xarray/issues/1821 MDEyOklzc3VlQ29tbWVudDM2NTM1MjEzMg== czr137 6153603 2018-02-13T18:05:06Z 2018-02-13T18:05:06Z CONTRIBUTOR

1865

It's a simple fix, but it affects my ability to produce CF1.7 netCDF files for distribution of our satellite data. The pull request #1869 is ready to go.

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
  v0.10.1 Release 287852184
356999205 https://github.com/pydata/xarray/issues/1821#issuecomment-356999205 https://api.github.com/repos/pydata/xarray/issues/1821 MDEyOklzc3VlQ29tbWVudDM1Njk5OTIwNQ== dcherian 2448579 2018-01-11T17:22:56Z 2018-01-11T17:22:56Z MEMBER

https://github.com/pydata/xarray/issues?q=is%3Aissue+milestone%3A0.10.1+is%3Aopen

{
    "total_count": 1,
    "+1": 1,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
  v0.10.1 Release 287852184

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options:

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);
Powered by Datasette · Queries took 15.303ms · About: xarray-datasette