issue_comments

Table actions

6 rows where issue = 284607311 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: reactions, created_at (date), updated_at (date)

user 3

issue 1

  • WIP: Performance improvements for zarr backend · 6 ✖

author_association 1

id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
360160914 https://github.com/pydata/xarray/pull/1800#issuecomment-360160914 https://api.github.com/repos/pydata/xarray/issues/1800 MDEyOklzc3VlQ29tbWVudDM2MDE2MDkxNA== mrocklin 306380 2018-01-24T14:56:57Z 2018-01-24T14:56:57Z MEMBER

Woot.

On Wed, Jan 24, 2018 at 9:55 AM, Joe Hamman notifications@github.com wrote:

Merged #1800 https://github.com/pydata/xarray/pull/1800.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/pydata/xarray/pull/1800#event-1439664156, or mute the thread https://github.com/notifications/unsubscribe-auth/AASszIIrZcJD3vsuqHKJT_8sL7Ryrqljks5tN0R7gaJpZM4RM_pa . 

{
    "total_count": 1,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 1,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   WIP: Performance improvements for zarr backend 284607311
357729370 https://github.com/pydata/xarray/pull/1800#issuecomment-357729370 https://api.github.com/repos/pydata/xarray/issues/1800 MDEyOklzc3VlQ29tbWVudDM1NzcyOTM3MA== jhamman 2443309 2018-01-15T16:22:52Z 2018-01-15T16:22:52Z MEMBER

Time for final comments. I'll merge tomorrow if nobody has any further changes. 

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   WIP: Performance improvements for zarr backend 284607311
357475185 https://github.com/pydata/xarray/pull/1800#issuecomment-357475185 https://api.github.com/repos/pydata/xarray/issues/1800 MDEyOklzc3VlQ29tbWVudDM1NzQ3NTE4NQ== rabernat 1197350 2018-01-13T23:16:38Z 2018-01-13T23:17:24Z MEMBER

Eventually we will want to think about testing xarray / zarr / gcsfs integration automatically somewhere. (but not here and not now)

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   WIP: Performance improvements for zarr backend 284607311
357471469 https://github.com/pydata/xarray/pull/1800#issuecomment-357471469 https://api.github.com/repos/pydata/xarray/issues/1800 MDEyOklzc3VlQ29tbWVudDM1NzQ3MTQ2OQ== jhamman 2443309 2018-01-13T22:15:47Z 2018-01-13T22:15:47Z MEMBER

@rabernat - thanks for the review. I've addressed all your comments. I've also tested using this to push data to GCS. We're still getting the best performance we've been able to get when this is combined with gcsf:master and zarr:master. 

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   WIP: Performance improvements for zarr backend 284607311
356664779 https://github.com/pydata/xarray/pull/1800#issuecomment-356664779 https://api.github.com/repos/pydata/xarray/issues/1800 MDEyOklzc3VlQ29tbWVudDM1NjY2NDc3OQ== jhamman 2443309 2018-01-10T16:54:51Z 2018-01-10T16:54:51Z MEMBER

This is ready for some final reviews. Although the title refers to Zarr, I ended up doing some minor refactoring of all the backends so a critical eye there would be nice. I'm also hoping to use @shoyer's coding/encoding work in #1803 here once that is merged.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   WIP: Performance improvements for zarr backend 284607311
354711613 https://github.com/pydata/xarray/pull/1800#issuecomment-354711613 https://api.github.com/repos/pydata/xarray/issues/1800 MDEyOklzc3VlQ29tbWVudDM1NDcxMTYxMw== jhamman 2443309 2018-01-02T07:02:06Z 2018-01-02T07:02:06Z MEMBER

@shoyer - I've added a set_dimensions method to the writable datastores. This seems to work quite well except for string variables. I have a hacky fix with a comment in there right now, this works for all backends except h5netcdf. Thoughts on a better way to encode variables prior to setting dimensions would be great.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   WIP: Performance improvements for zarr backend 284607311

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);