issue_comments

Table actions

4 rows where issue = 279198672 and user = 306380 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: created_at (date), updated_at (date)

user 1

  • mrocklin · 4 ✖

issue 1

  • Fix DataArray.__dask_scheduler__ to point to dask.threaded.get · 4 ✖

author_association 1

id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
350108925 https://github.com/pydata/xarray/pull/1760#issuecomment-350108925 https://api.github.com/repos/pydata/xarray/issues/1760 MDEyOklzc3VlQ29tbWVudDM1MDEwODkyNQ== mrocklin 306380 2017-12-07T22:05:44Z 2017-12-07T22:05:44Z MEMBER

Done. Tests pass.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Fix DataArray.__dask_scheduler__ to point to dask.threaded.get 279198672
349964478 https://github.com/pydata/xarray/pull/1760#issuecomment-349964478 https://api.github.com/repos/pydata/xarray/issues/1760 MDEyOklzc3VlQ29tbWVudDM0OTk2NDQ3OA== mrocklin 306380 2017-12-07T13:19:18Z 2017-12-07T13:19:18Z MEMBER

@shoyer how would you like me to proceed here? Should I drop the current modifications to the .compute methods and just leave in the __dask_scheduler__ fix?

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Fix DataArray.__dask_scheduler__ to point to dask.threaded.get 279198672
349179082 https://github.com/pydata/xarray/pull/1760#issuecomment-349179082 https://api.github.com/repos/pydata/xarray/issues/1760 MDEyOklzc3VlQ29tbWVudDM0OTE3OTA4Mg== mrocklin 306380 2017-12-05T02:54:37Z 2017-12-05T02:54:37Z MEMBER

Has that changed? Does dask.compute(x) call x.compute()?

No, we no longer call Array.compute at all

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Fix DataArray.__dask_scheduler__ to point to dask.threaded.get 279198672
349151580 https://github.com/pydata/xarray/pull/1760#issuecomment-349151580 https://api.github.com/repos/pydata/xarray/issues/1760 MDEyOklzc3VlQ29tbWVudDM0OTE1MTU4MA== mrocklin 306380 2017-12-05T00:15:03Z 2017-12-05T00:15:03Z MEMBER

The mock tests still fail for me. I'm not sure how best to generalize them. Recommendations would be welcome here.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Fix DataArray.__dask_scheduler__ to point to dask.threaded.get 279198672

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);