issue_comments

Table actions

4 rows where issue = 278743801 sorted by updated_at descending

✖
✖

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: reactions, created_at (date), updated_at (date)

author_association 2

issue 1

  • open_dataarray docs still contains *args, **kwargs · 4 ✖
id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
349175571 https://github.com/pydata/xarray/issues/1757#issuecomment-349175571 https://api.github.com/repos/pydata/xarray/issues/1757 MDEyOklzc3VlQ29tbWVudDM0OTE3NTU3MQ== raybellwaves 17162724 2017-12-05T02:31:56Z 2017-12-07T03:23:51Z CONTRIBUTOR

@jhamman it was just a quick comparison with the docs online

see http://xarray.pydata.org/en/stable/generated/xarray.open_dataset.html vs http://xarray.pydata.org/en/stable/generated/xarray.open_dataarray.html

The stickler in me wants to ensure the docs are the same for both functions (i.e. list the inputs are the same) between open_dataset and open_dataarray. I thought it was just a 2 second copy and paste fix but my PR, but it's failing so i'll take another look.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   open_dataarray docs still contains *args, **kwargs 278743801
349177419 https://github.com/pydata/xarray/issues/1757#issuecomment-349177419 https://api.github.com/repos/pydata/xarray/issues/1757 MDEyOklzc3VlQ29tbWVudDM0OTE3NzQxOQ== fujiisoup 6815844 2017-12-05T02:44:02Z 2017-12-05T02:44:02Z MEMBER

I think this is a documentation issue.

From the user side, it would be easier to understand if the arguments of this function are explicitly listed; auto-completion or function help in Ipython would also work.

But from the developer side, the explicit arguments will increase the risk of bugs.

Personally, I prefer the explicit function arguments, but I will not oppose the decision by the group.

 
{
    "total_count": 1,
    "+1": 1,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   open_dataarray docs still contains *args, **kwargs 278743801
349106003 https://github.com/pydata/xarray/issues/1757#issuecomment-349106003 https://api.github.com/repos/pydata/xarray/issues/1757 MDEyOklzc3VlQ29tbWVudDM0OTEwNjAwMw== jhamman 2443309 2017-12-04T21:08:29Z 2017-12-04T21:08:29Z MEMBER

@raybellwaves - can you explain what specific problem the current open_dataarray signature is causing? The *args and **kwargs appear to be correctly passed onto the open_dataset call.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   open_dataarray docs still contains *args, **kwargs 278743801
348744269 https://github.com/pydata/xarray/issues/1757#issuecomment-348744269 https://api.github.com/repos/pydata/xarray/issues/1757 MDEyOklzc3VlQ29tbWVudDM0ODc0NDI2OQ== fujiisoup 6815844 2017-12-03T06:42:24Z 2017-12-03T06:42:24Z MEMBER

Hi, raybellwaves,

I think open_dataarray also should provide the full input parameters. This is written here.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   open_dataarray docs still contains *args, **kwargs 278743801

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);