issue_comments

Table actions

2 rows where issue = 278713328 and user = 28786187 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: created_at (date), updated_at (date)

user 1

  • st-bender · 2 ✖

issue 1

  • Deprecate inplace methods · 2 ✖

author_association 1

id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
457527937 https://github.com/pydata/xarray/issues/1756#issuecomment-457527937 https://api.github.com/repos/pydata/xarray/issues/1756 MDEyOklzc3VlQ29tbWVudDQ1NzUyNzkzNw== st-bender 28786187 2019-01-25T10:28:04Z 2019-01-25T10:28:04Z CONTRIBUTOR

Hi, Thanks for the replies, I was indeed caught by surprise and given that the version number is 0.11.x, I had the impression that 0.12.x would be the next major minor release (and coming soon).

@shoyer In that case I would take it back and vote for a change as soon as possible to stabilize the API. Although xarray is still considered beta, I guess some people already use it productively.

@jhamman Thanks for the offer, I think the changes were simple enough. I merely wanted to point out that some more people use(d) that feature.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Deprecate inplace methods 278713328
457131090 https://github.com/pydata/xarray/issues/1756#issuecomment-457131090 https://api.github.com/repos/pydata/xarray/issues/1756 MDEyOklzc3VlQ29tbWVudDQ1NzEzMTA5MA== st-bender 28786187 2019-01-24T09:40:01Z 2019-01-24T09:40:01Z CONTRIBUTOR

Hi, Sorry for the late comment about a closed bug. But I find changing the API a bit irritating to say the least, and this is a serious change. Although apparently not many people use it, some actually may (myself included). And so far there has been only one bug report, so what problem are you trying to fix? I can fix my own code but there may be others out there that cannot keep pace with the development and including their packages may then break software. For my taste the deprecation warning is a bit short if you are going to remove such a feature already in the next version. A few more cycles would be appreciated.

At the very least put a big warning sign to the documentation that xarray is still beta and the API is still subject to change.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Deprecate inplace methods 278713328

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);