issue_comments

Table actions

3 rows where issue = 274996832 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: reactions, created_at (date), updated_at (date)

user 2

author_association 2

issue 1

  • Behavior of dataarray with no dimensions · 3 ✖
id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
346106494 https://github.com/pydata/xarray/issues/1726#issuecomment-346106494 https://api.github.com/repos/pydata/xarray/issues/1726 MDEyOklzc3VlQ29tbWVudDM0NjEwNjQ5NA== 0x0L 3621629 2017-11-21T17:47:44Z 2017-11-21T19:41:46Z CONTRIBUTOR

I dug it a bit further. Contrary to what I said numpy is fine. If x is a DataArray

```python np.array(x.mean())

-> array(2.0)

np.array([x.mean()])

-> array([2.0])

np.array(x)

-> ok

```

pandas behavior is more surprising

```python pd.Series(2)

ok

pd.Series(x.mean())

-> TypeError: len() of unsized object

pd.Series([x.mean()])

-> dtype=object

however for 1D x

pd.Series(x)

dtype is fine

```

Something looks a bit odd to me. But it looks more like a pandas issue

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Behavior of dataarray with no dimensions 274996832
345790125 https://github.com/pydata/xarray/issues/1726#issuecomment-345790125 https://api.github.com/repos/pydata/xarray/issues/1726 MDEyOklzc3VlQ29tbWVudDM0NTc5MDEyNQ== 0x0L 3621629 2017-11-20T18:47:12Z 2017-11-20T18:47:12Z CONTRIBUTOR

Thanks for your answer. I'll try to find a good spot in the doc to write a line or two about this.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Behavior of dataarray with no dimensions 274996832
345408336 https://github.com/pydata/xarray/issues/1726#issuecomment-345408336 https://api.github.com/repos/pydata/xarray/issues/1726 MDEyOklzc3VlQ29tbWVudDM0NTQwODMzNg== shoyer 1217238 2017-11-18T01:39:12Z 2017-11-18T01:39:17Z MEMBER

Yes, this was an intentional choice, though not without occasional regrets!

This is nice from an consistency perspective: every operation on an xarray object returns another xarray object. Also, as you point out, this allows us to preserve metadata such as attributes or scalar coordinates.

I'm going to mark this as a documentation issue: this would be a great thing to add our docs somewhere (maybe the FAQ page?).

 
{
    "total_count": 1,
    "+1": 1,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Behavior of dataarray with no dimensions 274996832

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);