issue_comments

Table actions

6 rows where issue = 274233261 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: reactions, created_at (date), updated_at (date)

author_association 2

issue 1

  • colorbars in facet grids · 6 ✖
id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
345795013 https://github.com/pydata/xarray/issues/1717#issuecomment-345795013 https://api.github.com/repos/pydata/xarray/issues/1717 MDEyOklzc3VlQ29tbWVudDM0NTc5NTAxMw== JoyMonteiro 7300413 2017-11-20T19:04:11Z 2017-11-20T19:04:11Z NONE

Great, will prepare a PR! I second @fmaussion on keeping the auto colorbar, just makes life easy!

 
{
    "total_count": 1,
    "+1": 1,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   colorbars in facet grids 274233261
345770964 https://github.com/pydata/xarray/issues/1717#issuecomment-345770964 https://api.github.com/repos/pydata/xarray/issues/1717 MDEyOklzc3VlQ29tbWVudDM0NTc3MDk2NA== shoyer 1217238 2017-11-20T17:39:07Z 2017-11-20T17:39:07Z MEMBER

I was thinking for everything. But I'm OK deferring to your judgment on this one :)

On Mon, Nov 20, 2017 at 9:26 AM Fabien Maussion notifications@github.com wrote:

it might be cleaner to avoid making a color-bar automatically in the same call to .plot()

For all 2D plots or just for facetgrids? In general I like the all-in-one feeling of xarray plots currently, and I imagine that the automatic colorbar is used very often.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/pydata/xarray/issues/1717#issuecomment-345767423, or mute the thread https://github.com/notifications/unsubscribe-auth/ABKS1o4i7stbLAdiYoeUgpe2QqEETQR5ks5s4bZXgaJpZM4QfQmj . 

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   colorbars in facet grids 274233261
345767423 https://github.com/pydata/xarray/issues/1717#issuecomment-345767423 https://api.github.com/repos/pydata/xarray/issues/1717 MDEyOklzc3VlQ29tbWVudDM0NTc2NzQyMw== fmaussion 10050469 2017-11-20T17:26:46Z 2017-11-20T17:26:46Z MEMBER

it might be cleaner to avoid making a color-bar automatically in the same call to .plot()

For all 2D plots or just for facetgrids? In general I like the all-in-one feeling of xarray plots currently, and I imagine that the automatic colorbar is used very often.

 
{
    "total_count": 2,
    "+1": 2,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   colorbars in facet grids 274233261
345765551 https://github.com/pydata/xarray/issues/1717#issuecomment-345765551 https://api.github.com/repos/pydata/xarray/issues/1717 MDEyOklzc3VlQ29tbWVudDM0NTc2NTU1MQ== shoyer 1217238 2017-11-20T17:20:36Z 2017-11-20T17:20:36Z MEMBER

Indeed, for consistency it would make sense to add cbar_kwargs. I'm just thinking that going forward (if we can solve the backwards compatibility problem) it might be cleaner to avoid making a color-bar automatically in the same call to .plot().

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   colorbars in facet grids 274233261
345761849 https://github.com/pydata/xarray/issues/1717#issuecomment-345761849 https://api.github.com/repos/pydata/xarray/issues/1717 MDEyOklzc3VlQ29tbWVudDM0NTc2MTg0OQ== fmaussion 10050469 2017-11-20T17:07:42Z 2017-11-20T17:07:42Z MEMBER

What are the arguments against cbar_kwargs ? This would be consistent with the API of the other 2D plots

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   colorbars in facet grids 274233261
345752241 https://github.com/pydata/xarray/issues/1717#issuecomment-345752241 https://api.github.com/repos/pydata/xarray/issues/1717 MDEyOklzc3VlQ29tbWVudDM0NTc1MjI0MQ== shoyer 1217238 2017-11-20T16:37:20Z 2017-11-20T16:37:20Z MEMBER

I don't think we have anything like this in the development version yet.

I wonder if it would be better to stop plotting colorbars automatically, and instead require explicitly calling add_colorbar()?

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   colorbars in facet grids 274233261

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);