issue_comments

Table actions

1 row where issue = 272460887 and user = 6815844 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: created_at (date), updated_at (date)

user 1

  • fujiisoup · 1 ✖

issue 1

  • Make Indexer classes not inherit from tuple. · 1 ✖

author_association 1

id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
343167809 https://github.com/pydata/xarray/pull/1705#issuecomment-343167809 https://api.github.com/repos/pydata/xarray/issues/1705 MDEyOklzc3VlQ29tbWVudDM0MzE2NzgwOQ== fujiisoup 6815844 2017-11-09T14:19:04Z 2017-11-09T14:19:04Z MEMBER

This looks pretty clean and less error-prone.

For more cleanliness, I'm wondering if we could more clearly distinguish between raw array-wrappers (such as NumpyIndexingAdapter) and wrappers of array-wrapper (such as MemoryCachedArray). But as a whole, I like this idea.

Regarding the more array-type support in the future (as suggested in comment), is there something to prepare in this PR? I guess there are some typical indexing types, such as Fortran-type and Numpy-type. Can we have some abstract classes (maybe too early)?

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Make Indexer classes not inherit from tuple. 272460887

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);