issue_comments

Table actions

2 rows where issue = 272325640 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: created_at (date), updated_at (date)

user 2

author_association 2

issue 1

  • fix empty dataset from_dict · 2 ✖
id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
389041983 https://github.com/pydata/xarray/pull/1702#issuecomment-389041983 https://api.github.com/repos/pydata/xarray/issues/1702 MDEyOklzc3VlQ29tbWVudDM4OTA0MTk4Mw== chrisbarber 1530840 2018-05-15T04:51:03Z 2018-05-15T04:51:03Z NONE

Just doing some garbage-collection; it looks like this was somehow fixed. This works in 0.10.0 and 0.10.3: ```

ds = xr.Dataset({'a': ('b', [])}) xr.Dataset.equals(ds, xr.Dataset.from_dict(ds.to_dict())) True ```

 
{
    "total_count": 1,
    "+1": 1,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   fix empty dataset from_dict 272325640
342988690 https://github.com/pydata/xarray/pull/1702#issuecomment-342988690 https://api.github.com/repos/pydata/xarray/issues/1702 MDEyOklzc3VlQ29tbWVudDM0Mjk4ODY5MA== shoyer 1217238 2017-11-08T22:53:50Z 2017-11-08T22:53:50Z MEMBER

Not sure if you want an issue or a whats-new entry for a small fix like this.

Yes, this would be still be appreciated. Something like "Fix Dataset.from_dict() for size zero inputs" in the bug-fixes section would suffice.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   fix empty dataset from_dict 272325640

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);