issue_comments

Table actions

10 rows where issue = 271599372 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: created_at (date), updated_at (date)

user 2

issue 1

  • Regression: dropna() on lazy variable · 10 ✖

author_association 1

id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
342790236 https://github.com/pydata/xarray/issues/1694#issuecomment-342790236 https://api.github.com/repos/pydata/xarray/issues/1694 MDEyOklzc3VlQ29tbWVudDM0Mjc5MDIzNg== fujiisoup 6815844 2017-11-08T11:28:48Z 2017-11-08T13:49:01Z MEMBER

I sent a PR just adding your particular code in the test suit. This test passed also in travis.

I think something goes wrong in your environment. Probably __pycache__ issue?

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Regression: dropna() on lazy variable 271599372
342819092 https://github.com/pydata/xarray/issues/1694#issuecomment-342819092 https://api.github.com/repos/pydata/xarray/issues/1694 MDEyOklzc3VlQ29tbWVudDM0MjgxOTA5Mg== fmaussion 10050469 2017-11-08T13:36:09Z 2017-11-08T13:36:09Z MEMBER

My apologies! It's my mistake. I think I was using the old-beta :-( 

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Regression: dropna() on lazy variable 271599372
342779834 https://github.com/pydata/xarray/issues/1694#issuecomment-342779834 https://api.github.com/repos/pydata/xarray/issues/1694 MDEyOklzc3VlQ29tbWVudDM0Mjc3OTgzNA== fujiisoup 6815844 2017-11-08T10:44:28Z 2017-11-08T12:30:22Z MEMBER

@fmaussion Oh, really? In my environment, the current master works without problems. But I did not include the particular case you suggested here...

I will add the test and check in travis.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Regression: dropna() on lazy variable 271599372
342770771 https://github.com/pydata/xarray/issues/1694#issuecomment-342770771 https://api.github.com/repos/pydata/xarray/issues/1694 MDEyOklzc3VlQ29tbWVudDM0Mjc3MDc3MQ== fmaussion 10050469 2017-11-08T10:09:13Z 2017-11-08T10:09:13Z MEMBER

(sorry these internal stuffs are causing such a trouble :()

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Regression: dropna() on lazy variable 271599372
342770263 https://github.com/pydata/xarray/issues/1694#issuecomment-342770263 https://api.github.com/repos/pydata/xarray/issues/1694 MDEyOklzc3VlQ29tbWVudDM0Mjc3MDI2Mw== fmaussion 10050469 2017-11-08T10:07:16Z 2017-11-08T10:07:16Z MEMBER

@fujiisoup did you test it my code in #1693 ?

It still doesn't work for me locally

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Regression: dropna() on lazy variable 271599372
342619528 https://github.com/pydata/xarray/issues/1694#issuecomment-342619528 https://api.github.com/repos/pydata/xarray/issues/1694 MDEyOklzc3VlQ29tbWVudDM0MjYxOTUyOA== fmaussion 10050469 2017-11-07T20:57:03Z 2017-11-07T20:57:03Z MEMBER 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Regression: dropna() on lazy variable 271599372
342362465 https://github.com/pydata/xarray/issues/1694#issuecomment-342362465 https://api.github.com/repos/pydata/xarray/issues/1694 MDEyOklzc3VlQ29tbWVudDM0MjM2MjQ2NQ== fujiisoup 6815844 2017-11-07T03:12:13Z 2017-11-07T03:12:13Z MEMBER

Sent a fix in #1693

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Regression: dropna() on lazy variable 271599372
342328151 https://github.com/pydata/xarray/issues/1694#issuecomment-342328151 https://api.github.com/repos/pydata/xarray/issues/1694 MDEyOklzc3VlQ29tbWVudDM0MjMyODE1MQ== fujiisoup 6815844 2017-11-06T23:54:57Z 2017-11-06T23:58:59Z MEMBER

This seems multicausal.

  • One reason is #1688, will be fixed in #1693.
  • The other cause is that MemoryCachedArray still stores bare np.ndarray, although it should be wrapped by NumpyIndexingAdapter in here I thought this was fixed #1676.
 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Regression: dropna() on lazy variable 271599372
342311816 https://github.com/pydata/xarray/issues/1694#issuecomment-342311816 https://api.github.com/repos/pydata/xarray/issues/1694 MDEyOklzc3VlQ29tbWVudDM0MjMxMTgxNg== fmaussion 10050469 2017-11-06T22:38:16Z 2017-11-06T22:38:16Z MEMBER

PR #1693 seems to solve this, but not found the cause yet.

Yes I wondered about this, but it looked like another issue since the traceback is very different. Thanks for all this work @fujiisoup !

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Regression: dropna() on lazy variable 271599372
342309617 https://github.com/pydata/xarray/issues/1694#issuecomment-342309617 https://api.github.com/repos/pydata/xarray/issues/1694 MDEyOklzc3VlQ29tbWVudDM0MjMwOTYxNw== fujiisoup 6815844 2017-11-06T22:29:23Z 2017-11-06T22:29:23Z MEMBER

@fmaussion Thanks for the report. PR #1693 seems to solve this, but not found the cause yet. I will investigate.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Regression: dropna() on lazy variable 271599372

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);