issue_comments

Table actions

10 rows where issue = 269886091 and user = 306380 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: created_at (date), updated_at (date)

user 1

  • mrocklin · 10 ✖

issue 1

  • Support Dask interface · 10 ✖

author_association 1

id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
342579451 https://github.com/pydata/xarray/pull/1674#issuecomment-342579451 https://api.github.com/repos/pydata/xarray/issues/1674 MDEyOklzc3VlQ29tbWVudDM0MjU3OTQ1MQ== mrocklin 306380 2017-11-07T18:37:04Z 2017-11-07T18:37:04Z MEMBER

Great. I'm glad to see this in. Thanks for the help!

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Support Dask interface 269886091
342469670 https://github.com/pydata/xarray/pull/1674#issuecomment-342469670 https://api.github.com/repos/pydata/xarray/issues/1674 MDEyOklzc3VlQ29tbWVudDM0MjQ2OTY3MA== mrocklin 306380 2017-11-07T12:37:06Z 2017-11-07T12:37:06Z MEMBER

Thank you for stepping in @shoyer .

From my perspective this is good to go. However I'm also not in any rush.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Support Dask interface 269886091
342247319 https://github.com/pydata/xarray/pull/1674#issuecomment-342247319 https://api.github.com/repos/pydata/xarray/issues/1674 MDEyOklzc3VlQ29tbWVudDM0MjI0NzMxOQ== mrocklin 306380 2017-11-06T18:50:33Z 2017-11-06T18:50:33Z MEMBER

I just tried things and persisting datasets seems to work well for me in practice.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Support Dask interface 269886091
341869434 https://github.com/pydata/xarray/pull/1674#issuecomment-341869434 https://api.github.com/repos/pydata/xarray/issues/1674 MDEyOklzc3VlQ29tbWVudDM0MTg2OTQzNA== mrocklin 306380 2017-11-04T03:50:23Z 2017-11-04T03:50:23Z MEMBER

Looks good to me, though it still needs the note in "What's new". This is pretty slow-risk in its current state (just adding new methods), so I would be OK including it in v0.10.

So, we're currently labeling the Dask collection interface (what we've implemented here) as experimental and subject to change without a deprecation cycle. I don't foresee much changing, but it might be wise to let people experiment with this in master for a while without putting it in the release. I would not be surprised if we find issues with it after moderate use.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Support Dask interface 269886091
341221791 https://github.com/pydata/xarray/pull/1674#issuecomment-341221791 https://api.github.com/repos/pydata/xarray/issues/1674 MDEyOklzc3VlQ29tbWVudDM0MTIyMTc5MQ== mrocklin 306380 2017-11-01T19:57:11Z 2017-11-01T19:57:11Z MEMBER

OK, this is now backwards compatible. Tests should pass.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Support Dask interface 269886091
341203737 https://github.com/pydata/xarray/pull/1674#issuecomment-341203737 https://api.github.com/repos/pydata/xarray/issues/1674 MDEyOklzc3VlQ29tbWVudDM0MTIwMzczNw== mrocklin 306380 2017-11-01T18:52:50Z 2017-11-01T18:52:50Z MEMBER

OK, this is now backwards compatible. I'll need to appropriately skip the tests if a new version of dask/dask and dask/distributed aren't around, but this change should be innocuous otherwise.

Review from @jhamman or @shoyer would be welcome.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Support Dask interface 269886091
341039156 https://github.com/pydata/xarray/pull/1674#issuecomment-341039156 https://api.github.com/repos/pydata/xarray/issues/1674 MDEyOklzc3VlQ29tbWVudDM0MTAzOTE1Ng== mrocklin 306380 2017-11-01T08:57:58Z 2017-11-01T08:57:58Z MEMBER

Generally yes, things work. There are a few xfailed failures in tests that used mock on functions that are no longer being used. Also xarray/tests/test_dask.py::test_dataarray_pickle is failing. Otherwise everything works well.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Support Dask interface 269886091
340877346 https://github.com/pydata/xarray/pull/1674#issuecomment-340877346 https://api.github.com/repos/pydata/xarray/issues/1674 MDEyOklzc3VlQ29tbWVudDM0MDg3NzM0Ng== mrocklin 306380 2017-10-31T19:16:26Z 2017-10-31T19:16:26Z MEMBER

I've updated this to dataarray and dataset as well

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Support Dask interface 269886091
340877260 https://github.com/pydata/xarray/pull/1674#issuecomment-340877260 https://api.github.com/repos/pydata/xarray/issues/1674 MDEyOklzc3VlQ29tbWVudDM0MDg3NzI2MA== mrocklin 306380 2017-10-31T19:16:05Z 2017-10-31T19:16:05Z MEMBER

For the distributed work this now also uses https://github.com/dask/distributed/pull/1513

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Support Dask interface 269886091
340704072 https://github.com/pydata/xarray/pull/1674#issuecomment-340704072 https://api.github.com/repos/pydata/xarray/issues/1674 MDEyOklzc3VlQ29tbWVudDM0MDcwNDA3Mg== mrocklin 306380 2017-10-31T09:17:56Z 2017-10-31T09:17:56Z MEMBER

I've only done Variable so far. Hopefully what's here seems straightforward. I'll do DataArray and DataSet next and then look at what legacy code I can clean up within XArray.

I'll be working on this while on a long flight and so may not respond quickly.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Support Dask interface 269886091

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);