issue_comments
6 rows where issue = 269348789 sorted by updated_at descending
This data as json, CSV (advanced)
Suggested facets: created_at (date), updated_at (date)
issue 1
- Remove use of allow_cleanup_failure in test_backends.py · 6 ✖
id | html_url | issue_url | node_id | user | created_at | updated_at ▲ | author_association | body | reactions | performed_via_github_app | issue |
---|---|---|---|---|---|---|---|---|---|---|---|
536336342 | https://github.com/pydata/xarray/issues/1668#issuecomment-536336342 | https://api.github.com/repos/pydata/xarray/issues/1668 | MDEyOklzc3VlQ29tbWVudDUzNjMzNjM0Mg== | max-sixty 5635139 | 2019-09-29T20:07:02Z | 2019-09-29T20:07:02Z | MEMBER | OK, yes I see now. I didn't know about that windows behavior. There's a broader CPython issue about it too. |
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
Remove use of allow_cleanup_failure in test_backends.py 269348789 | |
536238948 | https://github.com/pydata/xarray/issues/1668#issuecomment-536238948 | https://api.github.com/repos/pydata/xarray/issues/1668 | MDEyOklzc3VlQ29tbWVudDUzNjIzODk0OA== | shoyer 1217238 | 2019-09-29T01:39:05Z | 2019-09-29T01:39:05Z | MEMBER | It might more informative to try removing and this option and to see what fails when you run CI :). Our current temp file decorator will try to delete files as soon as we exit the scope, but if the file wasn't closed first this results in an exception on Windows. (This can happen because we only generate file names and let lower level library like netCDF open/close the files -- there are usually no Python level file objects, so we can't use |
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
Remove use of allow_cleanup_failure in test_backends.py 269348789 | |
536231578 | https://github.com/pydata/xarray/issues/1668#issuecomment-536231578 | https://api.github.com/repos/pydata/xarray/issues/1668 | MDEyOklzc3VlQ29tbWVudDUzNjIzMTU3OA== | max-sixty 5635139 | 2019-09-28T22:58:40Z | 2019-09-28T22:58:40Z | MEMBER |
IIUC (and my understand isn't advanced here!), python will close and delete temp files & directories once they leave scope: From https://docs.python.org/3/library/tempfile.html#examples ``` create a temporary file using a context manager
file is now closed and removed``` https://docs.python.org/3/library/tempfile.html#tempfile.TemporaryDirectory Or is it that we want to test that they're closed? |
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
Remove use of allow_cleanup_failure in test_backends.py 269348789 | |
536230684 | https://github.com/pydata/xarray/issues/1668#issuecomment-536230684 | https://api.github.com/repos/pydata/xarray/issues/1668 | MDEyOklzc3VlQ29tbWVudDUzNjIzMDY4NA== | shoyer 1217238 | 2019-09-28T22:37:46Z | 2019-09-28T22:37:46Z | MEMBER | We currently try to explicitly close any temp files we created at the end of each test. Are you suggesting that we should leave that clean-up to the operating system? |
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
Remove use of allow_cleanup_failure in test_backends.py 269348789 | |
536230085 | https://github.com/pydata/xarray/issues/1668#issuecomment-536230085 | https://api.github.com/repos/pydata/xarray/issues/1668 | MDEyOklzc3VlQ29tbWVudDUzNjIzMDA4NQ== | max-sixty 5635139 | 2019-09-28T22:26:03Z | 2019-09-28T22:26:03Z | MEMBER | Maybe I don't understand the whole problem—can we just use a temp dir for these? |
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
Remove use of allow_cleanup_failure in test_backends.py 269348789 | |
536229383 | https://github.com/pydata/xarray/issues/1668#issuecomment-536229383 | https://api.github.com/repos/pydata/xarray/issues/1668 | MDEyOklzc3VlQ29tbWVudDUzNjIyOTM4Mw== | stale[bot] 26384082 | 2019-09-28T22:11:04Z | 2019-09-28T22:11:04Z | NONE | In order to maintain a list of currently relevant issues, we mark issues as stale after a period of inactivity If this issue remains relevant, please comment here or remove the |
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
Remove use of allow_cleanup_failure in test_backends.py 269348789 |
Advanced export
JSON shape: default, array, newline-delimited, object
CREATE TABLE [issue_comments] ( [html_url] TEXT, [issue_url] TEXT, [id] INTEGER PRIMARY KEY, [node_id] TEXT, [user] INTEGER REFERENCES [users]([id]), [created_at] TEXT, [updated_at] TEXT, [author_association] TEXT, [body] TEXT, [reactions] TEXT, [performed_via_github_app] TEXT, [issue] INTEGER REFERENCES [issues]([id]) ); CREATE INDEX [idx_issue_comments_issue] ON [issue_comments] ([issue]); CREATE INDEX [idx_issue_comments_user] ON [issue_comments] ([user]);
user 3