issue_comments

Table actions

6 rows where issue = 269143043 and user = 500246 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: created_at (date), updated_at (date)

user 1

  • gerritholl · 6 ✖

issue 1

  • ds.notnull() fails with AttributeError on pandas 0.21.0rc1 · 6 ✖

author_association 1

id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
340093042 https://github.com/pydata/xarray/issues/1663#issuecomment-340093042 https://api.github.com/repos/pydata/xarray/issues/1663 MDEyOklzc3VlQ29tbWVudDM0MDA5MzA0Mg== gerritholl 500246 2017-10-27T21:30:08Z 2017-10-27T21:30:08Z CONTRIBUTOR

Oh, I missed that. I should have tried with xarray master.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   ds.notnull() fails with AttributeError on pandas 0.21.0rc1 269143043
340032712 https://github.com/pydata/xarray/issues/1663#issuecomment-340032712 https://api.github.com/repos/pydata/xarray/issues/1663 MDEyOklzc3VlQ29tbWVudDM0MDAzMjcxMg== gerritholl 500246 2017-10-27T17:20:58Z 2017-10-27T17:20:58Z CONTRIBUTOR

I'm not sure if I understand correctly, but it appears xarray has a hardcoded list of names of pandas functions/methods that need to be treated in a particular way. I might be on the wrong track though.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   ds.notnull() fails with AttributeError on pandas 0.21.0rc1 269143043
340030194 https://github.com/pydata/xarray/issues/1663#issuecomment-340030194 https://api.github.com/repos/pydata/xarray/issues/1663 MDEyOklzc3VlQ29tbWVudDM0MDAzMDE5NA== gerritholl 500246 2017-10-27T17:10:54Z 2017-10-27T17:10:54Z CONTRIBUTOR

I think we'd need to change PANDAS_UNARY_FUNCTIONS = ['isnull', 'notnull'] in ops.py; I'll have a try.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   ds.notnull() fails with AttributeError on pandas 0.21.0rc1 269143043
340024686 https://github.com/pydata/xarray/issues/1663#issuecomment-340024686 https://api.github.com/repos/pydata/xarray/issues/1663 MDEyOklzc3VlQ29tbWVudDM0MDAyNDY4Ng== gerritholl 500246 2017-10-27T16:48:39Z 2017-10-27T16:48:39Z CONTRIBUTOR

What I still don't know: is this a bug in xarray or a bug in pandas? Or neither?

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   ds.notnull() fails with AttributeError on pandas 0.21.0rc1 269143043
340023539 https://github.com/pydata/xarray/issues/1663#issuecomment-340023539 https://api.github.com/repos/pydata/xarray/issues/1663 MDEyOklzc3VlQ29tbWVudDM0MDAyMzUzOQ== gerritholl 500246 2017-10-27T16:44:01Z 2017-10-27T16:44:01Z CONTRIBUTOR 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   ds.notnull() fails with AttributeError on pandas 0.21.0rc1 269143043
340006322 https://github.com/pydata/xarray/issues/1663#issuecomment-340006322 https://api.github.com/repos/pydata/xarray/issues/1663 MDEyOklzc3VlQ29tbWVudDM0MDAwNjMyMg== gerritholl 500246 2017-10-27T15:36:11Z 2017-10-27T15:36:11Z CONTRIBUTOR

Just confirmed this is caused by a change in pandas somewhere between 0.20.3 and 0.21.0rc1. I don't know if that is a bug in pandas, or a deliberate change that xarray will somehow need to handle, in particular after 0.21.0 final is released.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   ds.notnull() fails with AttributeError on pandas 0.21.0rc1 269143043

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);