issue_comments

Table actions

9 rows where issue = 268487752 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: created_at (date), updated_at (date)

author_association 2

issue 1

  • da.plot.pcolormesh fails when there is a datetime coordinate · 9 ✖
id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
340220857 https://github.com/pydata/xarray/issues/1661#issuecomment-340220857 https://api.github.com/repos/pydata/xarray/issues/1661 MDEyOklzc3VlQ29tbWVudDM0MDIyMDg1Nw== shoyer 1217238 2017-10-28T21:24:52Z 2017-10-28T21:24:52Z MEMBER

Thanks @gerritholl and @TomAugspurger for your help figuring this out.

See #1669 for a fix.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   da.plot.pcolormesh fails when there is a datetime coordinate 268487752
339525582 https://github.com/pydata/xarray/issues/1661#issuecomment-339525582 https://api.github.com/repos/pydata/xarray/issues/1661 MDEyOklzc3VlQ29tbWVudDMzOTUyNTU4Mg== TomAugspurger 1312546 2017-10-26T01:49:12Z 2017-10-26T01:49:12Z MEMBER

Yep, that was the change.

The fix is to explicitly register the converters before plotting:

python from pandas.tseries import converter converter.register()

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   da.plot.pcolormesh fails when there is a datetime coordinate 268487752
339515375 https://github.com/pydata/xarray/issues/1661#issuecomment-339515375 https://api.github.com/repos/pydata/xarray/issues/1661 MDEyOklzc3VlQ29tbWVudDMzOTUxNTM3NQ== gerritholl 500246 2017-10-26T00:40:20Z 2017-10-26T00:40:20Z CONTRIBUTOR

@TomAugspurger Is it this one?

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   da.plot.pcolormesh fails when there is a datetime coordinate 268487752
339510522 https://github.com/pydata/xarray/issues/1661#issuecomment-339510522 https://api.github.com/repos/pydata/xarray/issues/1661 MDEyOklzc3VlQ29tbWVudDMzOTUxMDUyMg== TomAugspurger 1312546 2017-10-26T00:05:57Z 2017-10-26T00:05:57Z MEMBER

Pandas used to register a matplotlib converter for datetimes on import. I’ll take a closer look in a bit. 

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   da.plot.pcolormesh fails when there is a datetime coordinate 268487752
339467595 https://github.com/pydata/xarray/issues/1661#issuecomment-339467595 https://api.github.com/repos/pydata/xarray/issues/1661 MDEyOklzc3VlQ29tbWVudDMzOTQ2NzU5NQ== gerritholl 500246 2017-10-25T20:52:30Z 2017-10-25T20:52:30Z CONTRIBUTOR 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   da.plot.pcolormesh fails when there is a datetime coordinate 268487752
339451381 https://github.com/pydata/xarray/issues/1661#issuecomment-339451381 https://api.github.com/repos/pydata/xarray/issues/1661 MDEyOklzc3VlQ29tbWVudDMzOTQ1MTM4MQ== gerritholl 500246 2017-10-25T19:54:34Z 2017-10-25T19:54:34Z CONTRIBUTOR

The problem is triggered by a recent change in pandas. I'm currently bisecting pandas to see where it is but it's a little slow due to the compilation at every step.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   da.plot.pcolormesh fails when there is a datetime coordinate 268487752
339430955 https://github.com/pydata/xarray/issues/1661#issuecomment-339430955 https://api.github.com/repos/pydata/xarray/issues/1661 MDEyOklzc3VlQ29tbWVudDMzOTQzMDk1NQ== gerritholl 500246 2017-10-25T18:44:37Z 2017-10-25T18:44:37Z CONTRIBUTOR

Actually, it isn't in matplotlib really. It's xarrays responsibility after all. To plot with pcolormesh, one needs to convert the date axis using datenum, see https://stackoverflow.com/a/27918586/974555 . When plotting with xarray, that is out of control of the user, so there must be some step within xarray to prepare this. What I still don't know is why my code (not this MWE, but my actual code) worked several months ago but not now.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   da.plot.pcolormesh fails when there is a datetime coordinate 268487752
339416758 https://github.com/pydata/xarray/issues/1661#issuecomment-339416758 https://api.github.com/repos/pydata/xarray/issues/1661 MDEyOklzc3VlQ29tbWVudDMzOTQxNjc1OA== gerritholl 500246 2017-10-25T17:58:34Z 2017-10-25T17:58:34Z CONTRIBUTOR

Never mind, this is in matplotlib. See https://github.com/matplotlib/matplotlib/issues/9577.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   da.plot.pcolormesh fails when there is a datetime coordinate 268487752
339413389 https://github.com/pydata/xarray/issues/1661#issuecomment-339413389 https://api.github.com/repos/pydata/xarray/issues/1661 MDEyOklzc3VlQ29tbWVudDMzOTQxMzM4OQ== gerritholl 500246 2017-10-25T17:47:19Z 2017-10-25T17:47:19Z CONTRIBUTOR

I'm quite sure it worked in the past, but trying old versions of xarray yields the same error, so either my memory is wrong, or this started failing due to changes in dependencies.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   da.plot.pcolormesh fails when there is a datetime coordinate 268487752

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);