issue_comments

Table actions

11 rows where issue = 268213436 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: created_at (date), updated_at (date)

user 4

author_association 2

issue 1

  • Test suite is failing on master: No module named 'hypothesis.extra.pytestplugin' · 11 ✖
id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
339400961 https://github.com/pydata/xarray/issues/1655#issuecomment-339400961 https://api.github.com/repos/pydata/xarray/issues/1655 MDEyOklzc3VlQ29tbWVudDMzOTQwMDk2MQ== jhamman 2443309 2017-10-25T17:07:50Z 2017-10-25T17:07:50Z MEMBER

Exactly, conda-forge bundles optional dependencies in addition to required ones (e.g. https://github.com/conda-forge/xarray-feedstock/issues/5). 

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Test suite is failing on master: No module named 'hypothesis.extra.pytestplugin' 268213436
339399837 https://github.com/pydata/xarray/issues/1655#issuecomment-339399837 https://api.github.com/repos/pydata/xarray/issues/1655 MDEyOklzc3VlQ29tbWVudDMzOTM5OTgzNw== shoyer 1217238 2017-10-25T17:03:59Z 2017-10-25T17:03:59Z MEMBER

Thanks for tracking this down! How did we even get hypothesis installed in our CI environment? I guess things tend to bring in extra dependencies....

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Test suite is failing on master: No module named 'hypothesis.extra.pytestplugin' 268213436
339398526 https://github.com/pydata/xarray/issues/1655#issuecomment-339398526 https://api.github.com/repos/pydata/xarray/issues/1655 MDEyOklzc3VlQ29tbWVudDMzOTM5ODUyNg== ocefpaf 950575 2017-10-25T16:59:33Z 2017-10-25T16:59:33Z CONTRIBUTOR

I removed the bad package and things should be back t normal. See https://anaconda.org/conda-forge/hypothesis/files?version=3.33.0

(Not sure what went wrong and I cannot look into it right now, but I guess that latest hypothesis is not crucial for you here.)

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Test suite is failing on master: No module named 'hypothesis.extra.pytestplugin' 268213436
339397323 https://github.com/pydata/xarray/issues/1655#issuecomment-339397323 https://api.github.com/repos/pydata/xarray/issues/1655 MDEyOklzc3VlQ29tbWVudDMzOTM5NzMyMw== jhamman 2443309 2017-10-25T16:55:32Z 2017-10-25T16:55:32Z MEMBER

There is now a open issue on conda-forge: https://github.com/conda-forge/hypothesis-feedstock/issues/16

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Test suite is failing on master: No module named 'hypothesis.extra.pytestplugin' 268213436
339396206 https://github.com/pydata/xarray/issues/1655#issuecomment-339396206 https://api.github.com/repos/pydata/xarray/issues/1655 MDEyOklzc3VlQ29tbWVudDMzOTM5NjIwNg== fmaussion 10050469 2017-10-25T16:51:49Z 2017-10-25T16:51:49Z MEMBER

So, I think we can conclude something went wrong with the conda-forge build of hypothesis or pytest.

Ping our conda-forge expert @ocefpaf as he might be interested

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Test suite is failing on master: No module named 'hypothesis.extra.pytestplugin' 268213436
339395150 https://github.com/pydata/xarray/issues/1655#issuecomment-339395150 https://api.github.com/repos/pydata/xarray/issues/1655 MDEyOklzc3VlQ29tbWVudDMzOTM5NTE1MA== jhamman 2443309 2017-10-25T16:48:12Z 2017-10-25T16:48:12Z MEMBER

I can add some information here.

  1. Conda forge gives us hypothesis: 3.33.0-py36_0 and pytest is loading it as a plugin
  2. Pinning the conda version of hypothesis to 3.23 corrects the problem.
  3. Uninstalling hypothesis solves the problem
  4. Pip installing hypothesis solves the problem

So, I think we can conclude something went wrong with the conda-forge build of hypothesis or pytest.

Since we don't use hypothesis, we can disable it in one of a few ways. I'll open a PR with a fix in a few minutes.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Test suite is failing on master: No module named 'hypothesis.extra.pytestplugin' 268213436
339208437 https://github.com/pydata/xarray/issues/1655#issuecomment-339208437 https://api.github.com/repos/pydata/xarray/issues/1655 MDEyOklzc3VlQ29tbWVudDMzOTIwODQzNw== shoyer 1217238 2017-10-25T04:08:40Z 2017-10-25T04:08:40Z MEMBER 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Test suite is failing on master: No module named 'hypothesis.extra.pytestplugin' 268213436
339177701 https://github.com/pydata/xarray/issues/1655#issuecomment-339177701 https://api.github.com/repos/pydata/xarray/issues/1655 MDEyOklzc3VlQ29tbWVudDMzOTE3NzcwMQ== shoyer 1217238 2017-10-25T00:37:57Z 2017-10-25T04:08:30Z MEMBER

~~Let's see what happens when I trigger a pandas build: https://travis-ci.org/pandas-dev/pandas/builds/292375726~~ It doesn't seem to be an issue for pandas.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Test suite is failing on master: No module named 'hypothesis.extra.pytestplugin' 268213436
339177348 https://github.com/pydata/xarray/issues/1655#issuecomment-339177348 https://api.github.com/repos/pydata/xarray/issues/1655 MDEyOklzc3VlQ29tbWVudDMzOTE3NzM0OA== shoyer 1217238 2017-10-25T00:35:21Z 2017-10-25T00:35:21Z MEMBER

I did a diff on the build output from passing and failing builds, and conda is installing literally the exact same upstream dependencies. I can't see any changes, beyond the time which the builds were run, how long downloads take and of course whether the test crashes at the end or not.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Test suite is failing on master: No module named 'hypothesis.extra.pytestplugin' 268213436
339161857 https://github.com/pydata/xarray/issues/1655#issuecomment-339161857 https://api.github.com/repos/pydata/xarray/issues/1655 MDEyOklzc3VlQ29tbWVudDMzOTE2MTg1Nw== jhamman 2443309 2017-10-24T23:00:51Z 2017-10-24T23:00:51Z MEMBER

I've been getting the same failure on #1609. Only on Python 3.5 and 3.6. 

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Test suite is failing on master: No module named 'hypothesis.extra.pytestplugin' 268213436
339161132 https://github.com/pydata/xarray/issues/1655#issuecomment-339161132 https://api.github.com/repos/pydata/xarray/issues/1655 MDEyOklzc3VlQ29tbWVudDMzOTE2MTEzMg== shoyer 1217238 2017-10-24T22:56:42Z 2017-10-24T22:56:42Z MEMBER

This is particularly puzzling because as far as I know, we don't even use this plugin.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Test suite is failing on master: No module named 'hypothesis.extra.pytestplugin' 268213436

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);